feat(diffusion): add LongLive WAN training path#4272
Open
AndysonYs wants to merge 2 commits into
Open
Conversation
Signed-off-by: Shuai Yang <shyang@nvidia.com>
Signed-off-by: Shuai Yang <shyang@nvidia.com>
Contributor
|
Could you please check the default LongLive 1.3B recipe? It looks internally inconsistent: Please make the default recipe runnable, or mark it as non-runnable and update the README/tests accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds the initial offline-latents LongLive WAN MVP requested in #4215, covering clean-history plus noisy-target temporal chunks with windowed attention defaults and SP/TP validation.
Changelog
longlive_wan_stepregistration so WAN recipes can select the LongLive forward step fromscripts/training/run_recipe.py.LongLiveWanForwardStepandLongLiveWanFlowMatchingPipelinefor clean-history plus noisy-target temporal chunk training.[S, S]masks for long sequences.self_attention_mask.scripts/validation/wan_sp_tp_tiny_parity.pyto verify tiny WAN TP/SP inference parity with exact tensor equality.GitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
Additional Information
pre-commit run --all-filespassed.python -m compileall -q scripts/validation/wan_sp_tp_tiny_parity.py src/megatron/bridge/diffusion/models/wan/longlive_wan_step.py src/megatron/bridge/diffusion/models/wan/longlive_wan_utils.py src/megatron/bridge/diffusion/models/wan/wan_model.py src/megatron/bridge/diffusion/recipes/wan/wan.py tests/unit_tests/diffusion/model/wan/test_longlive_wan_step.py tests/unit_tests/diffusion/recipes/wan/test_wan_recipe.pypassed.3244385: 35 passed, 26 warnings in 3.56s on 4x GB200.3244425:strict_equal=True,max_abs=0.00000000e+00.3244426: completed 1/1 iteration on 4x GB200 with 0 skipped and 0 NaN iterations.uvwas unavailable in the conda environment, so pre-commit was run directly after installingpre-commitinto the existingmb-longlive-wanenvironment.