fix: include seed dataset in builder repr for seed-only configs#361
Merged
johnnygreco merged 1 commit intomainfrom Mar 2, 2026
Merged
fix: include seed dataset in builder repr for seed-only configs#361johnnygreco merged 1 commit intomainfrom
johnnygreco merged 1 commit intomainfrom
Conversation
Contributor
Greptile SummaryFixed
|
| Filename | Overview |
|---|---|
| packages/data-designer-config/src/data_designer/config/config_builder.py | Fixed __repr__ method to check both no columns AND no seed config before returning empty representation |
| packages/data-designer-config/tests/config/test_config_builder.py | Added regression test to verify seed dataset is shown in repr when no columns are configured |
Last reviewed commit: 7af89c1
andreatgretel
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Fixes
DataDesignerConfigBuilderrepr behavior so seed-only configurations no longer appear empty in interactive use. Adds a regression test to ensure seed datasets remain visible when no columns are configured.🔄 Changes
🐛 Fixed
DataDesignerConfigBuilder.__repr__to returnDataDesignerConfigBuilder()only when both no columns and no seed dataset are configured.with_seed_dataset(...).🧪 Tests
test_repr_includes_seed_dataset_when_no_columnsinpackages/data-designer-config/tests/config/test_config_builder.py.packages/data-designer-config/src/data_designer/config/config_builder.py.7af89c1b.🔍 Attention Areas
packages/data-designer-config/src/data_designer/config/config_builder.py- This is a public-facing repr path used in notebook and interactive workflows.🤖 Generated with AI