Change to using .bias.nc instead of .satbias.nc (and some other changes)#191
Open
CoryMartin-NOAA wants to merge 11 commits intomainfrom
Open
Change to using .bias.nc instead of .satbias.nc (and some other changes)#191CoryMartin-NOAA wants to merge 11 commits intomainfrom
CoryMartin-NOAA wants to merge 11 commits intomainfrom
Conversation
CoryMartin-NOAA
requested review from
ADCollard,
HyundeokChoi-NOAA,
RussTreadon-NOAA,
Copilot and
nicholasesposito
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ObsForge’s GSI→JEDI bias-correction handling and workflow templates, primarily aligning output naming with the newer .bias.nc-style conventions and adjusting Rocoto task settings.
Changes:
- Rename staged/copied bias-correction tarball from
rad_varbc_params.tartovarbc_params.tarand prefix BUFR status log withOPREFIX. - Update
gsi_to_iodatarball contents to publish.bias.nc,.bias_cov.nc, and.tlapse.txtnames (while sourcing existing GSI-produced files). - Adjust the
gsi_to_iodaRocoto XML template to removepartition, updatenative, and switch task dependencies to attribute form.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
ush/python/pyobsforge/task/stage_output.py |
Stages BUFR status log with OPREFIX and stages renamed varbc_params.tar bias tarball. |
ush/python/pyobsforge/task/gsi_to_ioda.py |
Renames bias tarball output and repackages bias/tlapse files under new in-tar naming conventions. |
parm/gsi_to_ioda.xml.j2 |
Updates Rocoto task resource/dependency directives (native flags and taskdep syntax). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Three flake8 violations in `ush/python/pyobsforge/task/gsi_to_ioda.py` were causing the pytest workflow to fail. - **W291 (×2)**: Removed trailing whitespace from comment lines 332 and 347 - **E265**: Fixed missing space after `#` in block comment on line 348 ```python # Before # add the same file with a different name for the covariance file #(this is needed for the UFO varbc reader to read in the covariance info) # After # add the same file with a different name for the covariance file # (this is needed for the UFO varbc reader to read in the covariance info) ``` <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Fix the following flake8 linting errors in `ush/python/pyobsforge/task/gsi_to_ioda.py`: > > 1. **Line 332**: Remove trailing whitespace (W291) > 2. **Line 347**: Remove trailing whitespace (W291) > 3. **Line 348**: Block comment should start with '# ' - ensure there's a space after the '#' character (E265) > > These errors are causing the pytest workflow to fail in job 64188770067. > > ## Specific Changes Needed > > - Line 332: Remove any trailing spaces at the end of the line > - Line 347: Remove any trailing spaces at the end of the line > - Line 348: Change the comment format from `#(this is needed...` to `# (this is needed...` (add a space after the '#') > > The file is located at: `ush/python/pyobsforge/task/gsi_to_ioda.py` </details> <!-- START COPILOT CODING AGENT SUFFIX --> *This pull request was created from Copilot chat.* > <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/NOAA-EMC/obsForge/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: CoryMartin-NOAA <6354668+CoryMartin-NOAA@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the GSI to JEDI scripts for bias coefficients along with a few other minor fixes.