WIP: update constraints and scheduling EDSL services to use new safer version of user-code-runner library - #1857
Draft
dandelany wants to merge 17 commits into
Draft
WIP: update constraints and scheduling EDSL services to use new safer version of user-code-runner library#1857dandelany wants to merge 17 commits into
dandelany wants to merge 17 commits into
Conversation
…code-runner library, pass Temporal as a module instead of disallowed insecure host object, pass serializer to guest so that it can return a serialized string
…straints DSL node app inside the docker image instead of copying built files in
…ode-runner library
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The prior implementation prevented otherwise independent tests from being run in parallel, as doing so would cause primary key conflicts in the database. The new implementation makes the conflicting fields configurable, allowing the tests to be run concurrently. Additionally, the duplicated tear down code has been pulled into ExternalEventUtils Test resources for external sources have been collected into their own folder in the test resource directory. scheduling_source_A.json and scheduling_source_B.json were inlined as template Strings into ExternalEventUtils
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - full description to come
Depends on #1855 and forthcoming release of https://github.com/NASA-AMMOS/aerie-ts-user-code-runner