Only open new page if extension provides url - #1981
Open
JosephVolosin wants to merge 1 commit into
Open
Conversation
JosephVolosin
temporarily deployed
to
test-workflow
August 5, 2026 16:28 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
JosephVolosin
temporarily deployed
to
test-workflow
August 5, 2026 16:28 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
callExtensionto only attempt to open a new window if the extension's response had a non-emptyurlparameter. Currently as written, a new tab is opened on success regardless of what is sent in the response.ExtensionResponseis also updated to reflecturlas an optional parameter in the response.Based on the documentation, I think this is already how the feature is supposed to function. For reference