Skip to content

Update es lint config to ES6 - #408

Merged
jvigliotta merged 10 commits into
mainfrom
eslint-update
Sep 23, 2026
Merged

Update es lint config to ES6#408
jvigliotta merged 10 commits into
mainfrom
eslint-update

Conversation

@jvigliotta

@jvigliotta jvigliotta commented Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Closes: #407

This will fix our npm run lint and npm run lint:fix commands.

@jvigliotta
jvigliotta requested a review from davetsay March 5, 2026 00:11
@davetsay

davetsay commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

@jvigliotta , code looks good but i still cannot successfully run npm i in the codebase so cannot smoke test

@davetsay

davetsay commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

@jvigliotta , fixed the build error in this branch locally and ran. There are a lot of linting errors.

davetsay
davetsay requested changes Mar 6, 2026
View reviewed changes

@davetsay davetsay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs lint fix

@sonarqubecloud

sonarqubecloud Bot commented Mar 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jvigliotta
jvigliotta requested a review from davetsay April 24, 2026 19:36
@sonarqubecloud

sonarqubecloud Bot commented Apr 24, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@sonarqubecloud

sonarqubecloud Bot commented Jul 23, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@jvigliotta
jvigliotta changed the base branch from main to release/6.0.0 July 28, 2026 17:49
@jvigliotta
jvigliotta changed the base branch from release/6.0.0 to main September 16, 2026 18:40
davetsay
davetsay requested changes Sep 22, 2026
View reviewed changes

@davetsay davetsay left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both sonarcube findings can be fixed in this pr.
There is a inline fix not related to the code change that should be fixed.
running npm run lint results in errors, most likely due to the back merged code

Comment thread src/services/session/SessionService.js Outdated

@davetsay davetsay Sep 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually checking for maxIterations + 1, since currentIteration is 0 indexed.

@jvigliotta jvigliotta Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah >= should cover it

@jvigliotta
jvigliotta merged commit bdac2a3 into main Sep 23, 2026
1 check passed
@jvigliotta
jvigliotta deleted the eslint-update branch September 23, 2026 20:52
@sonarqubecloud

sonarqubecloud Bot commented Sep 23, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davetsay davetsay davetsay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update ESLint Config to ES6

2 participants

@jvigliotta @davetsay