Skip to content

Resolve "Add frontend vitest unit tests to ci and fix broken tests" - #397

Open
nick-greenwald wants to merge 3 commits into
mainfrom
389-add-frontend-vitest-unit-tests-to-ci-and-fix-broken-tests
Open

Resolve "Add frontend vitest unit tests to ci and fix broken tests"#397
nick-greenwald wants to merge 3 commits into
mainfrom
389-add-frontend-vitest-unit-tests-to-ci-and-fix-broken-tests

Conversation

@nick-greenwald

Copy link
Copy Markdown
Contributor

Fixes broken skeleton unit tests for various components and adds a unit test CI job.

@nick-greenwald nick-greenwald self-assigned this Aug 19, 2026
@nick-greenwald
nick-greenwald requested a review from a team as a code owner August 19, 2026 19:40
@nick-greenwald nick-greenwald added the sustainment Long-term sustainment activities and technical debt removal label Aug 19, 2026
@nick-greenwald nick-greenwald linked an issue Aug 19, 2026 that may be closed by this pull request
@github-project-automation github-project-automation Bot moved this to Todo in ANMS Aug 19, 2026
cache-dependency-path: anms-ui/package-lock.json
- name: Install dependencies
working-directory: anms-ui
run: npm ci
run: npm ci
- name: Run unit tests
working-directory: anms-ui
run: npx ng test --runner=vitest --no-watch
run: npm ci
- name: Run unit tests
working-directory: anms-ui
run: npx ng test --runner=vitest --no-watch
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@BrianSipos BrianSipos added this to the ANMS v3.0.0 milestone Aug 21, 2026

@d-linko d-linko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attempting running the testing locally
got

 Test Files  25 passed (25)
      Tests  62 passed (62)
     Errors  1 error

with the error HttpErrorResponse: Http failure response for http://localhost:3000/api/core/adms: 401 Unauthorized

and also in the logs im seeing

Failed to load ARIs HttpErrorResponse {
  headers: HttpHeaders {
    headers: undefined,
    normalizedNames: Map(0) {},
    lazyInit: [Function (anonymous)],
    lazyUpdate: null
  },
  status: 401,
  statusText: 'Unauthorized',
  url: 'http://localhost:3000/api/build/ari/all',
  ok: false,
  type: undefined,
  redirected: undefined,
  responseType: undefined,
  name: 'HttpErrorResponse',
  message: 'Http failure response for http://localhost:3000/api/build/ari/all: 401 Unauthorized',
  error: {
    extra: null,
    message: 'Unauthorized',
    messageId: 'auth.unauthorized',
    statusCode: 401,
    traceID: ''
  }
}

looks like its trying a different port is that different in the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sustainment Long-term sustainment activities and technical debt removal

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Add frontend vitest unit tests to CI and fix broken tests

5 participants