Enable and fix all -Wall warnings - #991
Open
AHSauge wants to merge 1 commit into
Open
Conversation
AHSauge
force-pushed
the
feature/enable-wall
branch
4 times, most recently
from
August 13, 2026 09:49
24d7316 to
11382c6
Compare
Contributor
Author
|
This became a bit more extensive to pass the pipeline, but it should be all good now. All the Qt foreach use is removed though since that started to trigger some deprecation warnings. |
AHSauge
force-pushed
the
feature/enable-wall
branch
5 times, most recently
from
August 13, 2026 11:16
b77b325 to
a7271f8
Compare
AHSauge
force-pushed
the
feature/enable-wall
branch
from
August 13, 2026 11:20
a7271f8 to
b3dba72
Compare
Contributor
Author
|
Finally builds. However, the Windows CI is hitting the same intermittent issue as #982 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables compilation with
-Wall -Werrorfor non-Windows targets, and fixes a number of hidden warnings in the code. There are some genuine bug fixes in here as well as a results, such as fixing an encoding issue in the spell checker.