Update to Lexilla/Scintilla 5.x and Scintillua 6.x - #990
Open
AHSauge wants to merge 1 commit into
Open
Conversation
AHSauge
force-pushed
the
feature/lexilla-5.x
branch
6 times, most recently
from
August 11, 2026 23:46
e560834 to
0438e1b
Compare
AHSauge
force-pushed
the
feature/lexilla-5.x
branch
from
August 11, 2026 23:52
0438e1b to
d5b819b
Compare
Contributor
Author
|
Ugh! Gotta love different include path strategies between *nix and Windows 😫 Anyway, finally builds on Windows. Look wise, it seems pretty similar on Linux and Windows |
AHSauge
marked this pull request as ready for review
August 12, 2026 00:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fairly bulky merge request, but this does upgrade to Lexilla/Scintilla 5.x and Scintillua 6.x
Some things to note
dep/scintilla/scintillashould be an unmodified copy from Mercurial.NOTE: This is AI generated codewhere there's bit more than a few lines changed. I don't see anything wrong in the code, but worth being aware of. In any case, this is the riskiest change here in terms of visual and behavioural changes.src/editor/TextEditor.cpp. I've kept the context menu as-is, but there are some entries that quite obviously could be dropped.@Murmele This is draft solely because I'm still testing this, but I would still very much appreciate reviewing. I don't anticipate large changes at this stage, but only minor tweaks to make sure the theme and style isn't broken.
Fixes #935