BACK-626 - Make task lifecycle commands local-first - #912
Open
shixi-li wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Hi maintainers — the fork CI workflow for this PR is currently awaiting approval. The local validation results are included in the PR description. When convenient, could you approve the workflow so the change can be evaluated? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task archive,task complete, andtask demoteresolve their targets from the local working-copy task corpustask viewandtask editAmbiguousTaskIdErrorbehavior for active/completed ID collisionsWhy
These three CLI commands still used the default cross-branch lookup twice: once during command preflight and again inside the Core mutation. That could trigger a remote fetch/full corpus load and produced different errors for tasks that exist only on another branch, despite the owner ruling that CLI task commands are local-only.
The Core methods now accept an optional third
TaskReadOptionsargument. Existing callers retain their current defaults; only the three CLI handlers opt intoincludeCrossBranch: falsefor both lookup stages.Validation
bun test --timeout=10000 src/test/local-task-command-performance.test.ts— 9 passedbunx tsc --noEmitbun run check .bun run buildCloses BACK-626.