fix(ui): keep bond-gated maker listings in the Order Chat sidebar - #150
Open
amuntri wants to merge 1 commit into
Open
fix(ui): keep bond-gated maker listings in the Order Chat sidebar#150amuntri wants to merge 1 commit into
amuntri wants to merge 1 commit into
Conversation
The sidebar projection only admitted maker rows whose local status is `pending`. A maker order whose anti-abuse bond is still unpaid is `waiting-maker-bond` on Mostro's side — and that is exactly what a session restore (MostroP2P#149) and `Action::Orders` (MostroP2P#145) write locally, because both report Mostro's authoritative status rather than the `pending` mostrix records at creation time. Result: after a faithful restore, bond-gated listings existed in SQLite but vanished from the sidebar, so there was nothing to select and every Shift shortcut silently had no target. Found while testing MostroP2P#149 against the live instance (bonds enabled, PoW 6). Admit `waiting-maker-bond` alongside `pending`; active, terminal and taker rows stay out, as before. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
order_chat_list_item_from_db_orderonly admits maker rows whose local status ispending. But a maker order whose anti-abuse bond is unpaid iswaiting-maker-bondon Mostro's side — and that is exactly what a session restore (#149) andAction::Orders(#145) write locally, because both report Mostro's authoritative status instead of thependingmostrix records at creation time.Net effect, observed on the live instance (bonds enabled, PoW 6): after a faithful restore the bond-gated listings existed in SQLite but vanished from the Order Chat sidebar, so there was nothing to select and every Shift shortcut silently had no target.
Fix
Admit
waiting-maker-bondalongsidepending. Active, terminal and taker rows stay out, as before. Two new tests: the bond-gated row stays; active/terminal/taker rows don't.cargo test --all-features→ 483 passed. Clippy-D warningsand fmt clean.Context
This is what makes #149 and #145 actually usable for bond-gated orders; without it the user cannot reach the restored row to pay the bond or cancel. Independent of both, so it can land on its own.
🤖 Generated with Claude Code