Repository navigation
ci: format, lint and test every pull request - #23
Conversation
Nothing built or tested a pull request before merge: release.yml runs only on a version tag. On #16 a merge commit that did not compile still showed a green status, because the only check was CodeRabbit's, paused before that commit. The new CI workflow runs on every pull request and every push to main: cargo fmt --check, clippy with -D warnings and cargo test (all --locked), plus a type check for x86_64-pc-windows-msvc, which AGENTS.md already asks for because of the #[cfg(unix)] code. Read-only token, no secrets, so fork PRs run it too. Regtest stays manual. AGENTS.md lists the workflow and says it does not replace running the checks locally and reporting the result. Closes #22 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016wLvM1GyzFZkzVQSWvWLzh
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. WalkthroughThe PR adds CI checks for pull requests and pushes to ChangesPull request CI
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other · Severity of issue fixed: Medium Possibly related PRs
Suggested labels: Merge Risk:
|
Summary
Adds
.github/workflows/ci.yml, so every pull request and every push tomainis formatted, linted and tested before review. Until now onlyrelease.ymlran these checks, and only when a version tag was pushed.Why: on #16, merge commit 6d23f5e did not compile and deleted the trusted-node tests, yet the PR showed green, because its only check was CodeRabbit's, which had paused before that commit.
Closes #22
What runs
Format, lint and testcargo fmt --all -- --check,cargo clippy --locked --all-targets -- -D warnings,cargo test --lockedCheck the Windows targetcargo check --locked --target x86_64-pc-windows-msvc --bin mostro-mcprelease.yml(dtolnay/rust-toolchain@stable,Swatinem/rust-cache@v2).permissions: contents: readand no secrets, so PRs from forks run it safely.mainare never cancelled.cargo build --releaseon every PR (cargo testalready compiles everything; the release workflow builds the packages).AGENTS.mdlists the workflow and says CI does not replace running the checks locally and reporting the result.After merge (repository setting)
Make Format, lint and test and Check the Windows target required status checks on
mainin branch protection. Until then CI shows the result but does not block a merge.Test plan
Run locally on this branch (Linux,
mainat 02ec324 plus this commit):cargo fmt --all -- --check: passcargo clippy --locked --all-targets -- -D warnings: passcargo test --locked: 188 unit and 21 stdio passed, 10 regtest ignoredcargo check --locked --target x86_64-pc-windows-msvc --bin mostro-mcp: passcheck,windows-check; triggerspull_request,pushtomain)Not run:
actionlint(not installed here). No regtest: nothing here changes how a tool talks to the node.🤖 Generated with Claude Code
https://claude.ai/code/session_016wLvM1GyzFZkzVQSWvWLzh
Summary by CodeRabbit