Skip to content

Optimizes Life() in general#7045

Open
dwasint wants to merge 44 commits into
Monkestation:mainfrom
dwasint:life_optimization
Open

Optimizes Life() in general#7045
dwasint wants to merge 44 commits into
Monkestation:mainfrom
dwasint:life_optimization

Conversation

@dwasint

@dwasint dwasint commented Jul 4, 2026

Copy link
Copy Markdown

About The Pull Request

Another step in the direction of cheap ass mobs

Why It's Good For The Game

updatehealth() is expensive and should be done once per life loop (at the end)

Changelog

🆑
/:cl:

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@dwasint dwasint changed the title Optimizes updatehealth() calls in Life() Optimizes Life() in general Jul 5, 2026
@github-actions github-actions Bot added MERGE CONFLICT This PR has conflicting changes with the main branch and can't be merged and removed MERGE CONFLICT This PR has conflicting changes with the main branch and can't be merged labels Jul 5, 2026

@realforest2001 realforest2001 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where exactly in code the issue is, but all rousmen, and likely other minor species mobs, die on spawn because their hearts don't work. Rousmen are also missing eyes and ears.

//initialize limbs first
create_bodyparts()

attribute_initialize() // chud shit

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be above create bodyparts in my own testing for nullspace organs

Comment thread code/modules/mob/vision_cone.dm Outdated
Comment thread code/modules/surgery/organs/internal/appendix.dm
Comment thread code/modules/surgery/organs/helpers.dm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sprites This affects the appearance of something in game. Such as an item or a wall.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants