Update some plexora functionality#7038
Open
flleeppyy wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
Code Maintenance
|
|
||
| // Check status by id or game port | ||
| /datum/controller/subsystem/plexora/proc/check_byondserver_status(id, port) | ||
| if (isnull(id) && isnull(port)) return |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (isnull(id) && isnull(port)) return | |
| iif(!id || !port) | |
| return |
| /datum/controller/subsystem/plexora/proc/check_byondserver_status(id) | ||
| if (isnull(id)) return | ||
| /datum/controller/subsystem/plexora/proc/check_servers() | ||
| if(!PLX_SHOULD_CHECK_SERVERS) |
Collaborator
There was a problem hiding this comment.
replace with a define block / config flag or remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Pulls over some functionality from Monkestation/Monkestation2.0#12038
It adds a sister server checker with the configuration IDs for each. I would have made it a config but I decided to just make it a macro. If you think you'll use it you can change it in the future.
Why It's Good For The Game
plexy up to date
Changelog
🆑
code: Updated Plexora code
/:cl:
Pre-Merge Checklist