Skip to content

[Feat] Mooncake|Posix#972

Open
UESTC-AHao wants to merge 1 commit into
ModelEngine-Group:developfrom
UESTC-AHao:dev_fh_mooncake_pipeline
Open

[Feat] Mooncake|Posix#972
UESTC-AHao wants to merge 1 commit into
ModelEngine-Group:developfrom
UESTC-AHao:dev_fh_mooncake_pipeline

Conversation

@UESTC-AHao

Copy link
Copy Markdown
Contributor

Purpose

UCM + Mooncake & Mooncake|Posix (Ascend 0.18.0)

Modifications

unified-cache-management\examples\ucm_mooncake_config.yaml

Test

30199e8c-578f-4868-9a91-77aa91c42065 524b5e04-2e4b-4d8c-b5c3-283018b00d56

@UESTC-AHao UESTC-AHao force-pushed the dev_fh_mooncake_pipeline branch 3 times, most recently from 9d4e4d6 to b0bd13a Compare May 21, 2026 11:53
Comment thread ucm/integration/vllm/ucm_connector.py
Comment thread ucm/store/fake/cc/fake_store.cc
Comment thread ucm/integration/vllm/ucm_connector.py Outdated
Comment thread ucm/store/mooncakestore/cc/mooncake_store.cc Outdated
@UESTC-AHao UESTC-AHao force-pushed the dev_fh_mooncake_pipeline branch from b0bd13a to 20ddb7d Compare May 27, 2026 02:58
Comment thread ucm/store/ucmstore_v1.h
Comment thread ucm/integration/vllm/ucm_connector.py Outdated
Comment thread ucm/integration/vllm/ucm_connector.py Outdated
@UESTC-AHao UESTC-AHao force-pushed the dev_fh_mooncake_pipeline branch 8 times, most recently from 7a70990 to bff2484 Compare May 28, 2026 12:31
@UESTC-AHao UESTC-AHao force-pushed the dev_fh_mooncake_pipeline branch 4 times, most recently from 7979410 to e1490d5 Compare June 4, 2026 12:35
@qyh111 qyh111 self-requested a review June 4, 2026 12:45
qyh111
qyh111 previously approved these changes Jun 4, 2026

@ygwpz ygwpz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up Review Summary

Status: All previous concerns have been addressed

After reviewing the current state of the PR, I can confirm that all concerns raised in previous reviews have been addressed:

  1. Thread-safety for _pending_dump_tasks (line 910) - Addressed: UESTC-AHao explained that wait_for_save and _drain_pending_dump_tasks are both called sequentially within the same scheduler main loop, so synchronization is unnecessary.

  2. Check result of unregister_buffer() (mooncake_store.cc:84) - Verified fixed: Warning log added for failed unregister operations (lines 84-87).

  3. Performance concern for per-request dump tasks - Addressed: UESTC-AHao confirmed no practical impact upon testing.

  4. Extract function to StoreV1 (fake_store.cc:85) - Addressed: Function already extracted in StoreV1.

  5. 3fsstore implementation of RegisterMemory (ucmstore_v1.h:161) - Verified: ds3fs_store.cc implements RegisterMemory at lines 174-179.

  6. Dump task leaking in C++ task map (line 750) - Verified fixed: Now using store.wait() to properly clean up tasks after completion.

  7. Async dump failure handling (line 909) - Addressed: Failed requests are properly returned as finished in get_finished.

Unresolved Issue: Merge Conflicts

Important: This PR currently has merge conflicts (mergeable_state: dirty). The branch needs to be rebased against the develop branch to resolve conflicts before merging.

Please rebase the branch and resolve any conflicts with the upstream develop branch.

@UESTC-AHao UESTC-AHao force-pushed the dev_fh_mooncake_pipeline branch from d31e443 to e578441 Compare June 15, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants