[Bugfix] Rectifying the Exception in Total Throughput Calculation Results#966
Open
Menglths wants to merge 1 commit into
Open
[Bugfix] Rectifying the Exception in Total Throughput Calculation Results#966Menglths wants to merge 1 commit into
Menglths wants to merge 1 commit into
Conversation
ygwpz
approved these changes
May 23, 2026
ygwpz
left a comment
ygwpz
left a comment
Contributor
There was a problem hiding this comment.
Reviewed. The fix correctly removes the duplicate completed_requests.append(metrics) call that would have caused double-counting of metrics when num_output_tokens > 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Rectifying the Exception in Full Throughput Calculation Results
Modifications
Delete the repeated calculation line from the token_banchmark.py file.
Test
All tests have passed.