-
Notifications
You must be signed in to change notification settings - Fork 0
Initial SSR Migration #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alessandro100
wants to merge
71
commits into
main
Choose a base branch
from
spike/ssr-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the migration to a SSR application using NextJs. For this PR, the Feed Detail Page (partially) and the About page were made server components as a proof of concept. This PR is not ready for PROD but as a great benchmark to keep development on SSR.
High Level Changes
Important follow up tasks
Future Improvements
Developer Tooling & Configuration:
.mcp.jsonto supportnext-devtoolsfor improved development experience. (.mcp.json).eslintrc.json)jest.config.ts)babel.config.js)Testing & E2E Updates:
NEXT_PUBLIC_*), updated test routes to match Next.js routing, and improved test reliability with more robust selectors and timeouts. (cypress.config.ts,cypress/e2e/addFeedForm.cy.ts,cypress/e2e/feeds.cy.ts,cypress/support/commands.ts) [1] [2] [3] [4] [5] [6] [7]cypress/fixtures/gtfs_feed_test-516.json)Documentation Improvements:
README.mdto reflect the migration to Next.js, updated environment variable instructions, added new scripts, and documented API type generation and E2E testing workflows. (README.md) [1] [2] [3]These changes collectively modernize the project, streamline development and deployment, and ensure tests and documentation are aligned with the new Next.js architecture.