Repository navigation
fix: speed up and checkpoint deletion of deprecated GBFS feeds - #1885
Merged
Merged
Conversation
davidgamez
changed the title
davidgamez
marked this pull request as ready for review
November 3, 2026 20:33
Collaborator
|
Once this is merged, we can safely up the homepage count from 6000 feeds to 7000. cc @Alessandro100 |
davidgamez
force-pushed
the
fix/gbfs-deprecate-feeds-slow-delete
branch
from
November 10, 2026 17:56
dfe473e to
700f1ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1870. Deprecated GBFS feeds were never deleted: each cascaded delete took 20-90s because three foreign key columns are not indexed, and all deletes ran in one transaction that rolled back when the connection dropped after about 53 min.
gbfsnotice.validation_report_id,gbfsendpointhttpaccesslog.gbfs_endpoint_idandgbfsfeedhttpaccesslog.gbfs_feed_id.deprecate_feeds.Expected behavior:
Feeds removed from
systems.csv(e.g.gbfs-dott-klagenfurt) are deleted, and a failed run keeps its progress.Testing tips:
Remove a system from
systems.csv, runscripts/populate-db.sh <systems.csv> gbfs, and check that the feed is gone.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything