feat(build): select MEOS type families with MobilityDB/MEOS-style build flags (stacks on #19)#22
Open
estebanzimanyi wants to merge 7 commits into
Open
Conversation
This was referenced Jun 13, 2026
… surface Bump codegen/input/meos-idl.json to the MEOS-API IDL and regenerate functions.GeneratedFunctions over the full consolidated superset: mul_* (incl. tbigint); minDistance; the circular-buffer and network-point MF-JSON readers; the ever- and always-covers families (ecovers_*/acovers_*); trgeo_*; the H3 / th3index family (ever_eq_h3indexset_th3index, h3index_in/out, H3Index lowered to long); PostgreSQL type I/O; tgeogpoint_great_circle_distance; meos_initialize_noexit_error_handler. 2916 functions.
Add the codegen exec step to jmeos-core so functions/GeneratedFunctions.java is produced from codegen/input/meos-idl.json during the build, and drop the committed copy.
Run meos_initialize() from the binding's load path so the allocator and collation are installed before any call. MEOS splits startup into granular steps; without the collation step, text comparisons route into varstr_cmp with an uninitialized collation and crash.
Call the generated functions class from TText and TextSet instead of the hand-maintained facade, so the text conversions use the canonical master names (cstring_to_text, text_to_cstring).
Resolve each function's family from the IDL family field that MEOS-API derives from the declaring header's meos/include/<family>/ subdirectory, falling back to the header-basename map for IDLs generated before that field existed. Extend the optional set to every family the surface exposes — CBUFFER, NPOINT, POSE, RGEO, H3, QUADBIN, POINTCLOUD, JSON, ARROW, RASTER — so an edge build drops any unused family with -D<FAMILY>=OFF (e.g. POINTCLOUD) to shrink its footprint. CORE is always emitted.
estebanzimanyi
force-pushed
the
feat/family-build-flags
branch
from
0fa82d7 to
0f86604
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functions.GeneratedFunctions facade is generated at build time from the MEOS IDL with the optional type families selected by the same flag names and ON|OFF (also 1|0) values as the MobilityDB/MEOS build: -DCBUFFER, -DNPOINT, -DPOSE, -DRGEO, -DH3. Every family is included by default; passing -DCBUFFER=OFF (or =0) drops that family's functions from the generated binding so a subset jar ships without it (RGEO needs POSE). FunctionsGenerator maps each function's source header to its family and omits excluded families; jmeos-core runs the generator at generate-sources (so the flag flows through mvn) and compiles the generated functions.GeneratedFunctions.