fix: preserve shareable app card buttons when forwarding - #2051
Open
YeungKC wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forwarding an app card with non-send Mixin links stripped its buttons. Align the shared action check with MixinNetwork/android-app#6565 so those buttons survive both individual and transcript forwarding.
Exclude the case-insensitive prefixes
mixin://send,mixin://mixin.one/send, andhttps://mixin.one/send. This also excludes send links with a user parameter, matching Android.Validation: app card tests and targeted Dart analysis passed; macOS debug build and launch succeeded. Tests cover allowed links, all three exclusions, mixed case, prefix matching, empty actions, and mixed button groups.