fix: avoid stalled message locate behind side routes - #2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locate from the pinned panel could stall in narrow layouts: the side route mutes the underlying chat's scroll ticker, while locating an already loaded message waits for that animation before closing the route. Jump without animation when locating will close a covering side route. Split layouts retain animated scrolling.
Added regression coverage using real Navigator routes and scrolling for narrow and split layouts, nearby and distant targets, and repeated jumps. Message reload is simulated in the test harness.
Validation: 39 focused tests and targeted Dart analysis passed. The macOS debug build launched successfully; manual testing reported no further issue.