fix: scope inactive ticker modes - #2046
Merged
Merged
Conversation
YeungKC
marked this pull request as ready for review
September 3, 2026 05:45
boyan01
approved these changes
Sep 3, 2026
YeungKC
marked this pull request as draft
September 3, 2026 05:55
YeungKC
marked this pull request as ready for review
September 3, 2026 05:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TickerModeso chat scrolling keeps animating when the desktop window loses focusAppActiveTickerModeand apply it to the input subtree, image preview, and message itemVoiceRecorderBottomBaroutside the input ticker scopeTests
flutter analyze --no-pub lib/app.dart lib/ui/home/chat/input_container.dart lib/utils/app_lifecycle.dart lib/widgets/message/item/image/image_preview_page.dart lib/widgets/message/message.dart test/widgets/message/message_context_test.dartflutter test --no-pub test/widgets/message/message_context_test.dart --plain-name "inactive mutes message ticker while sibling scroll still animates"flutter test --no-pub test/ui/home/chat/voice_recorder_overlay_test.dartflutter test --no-pub test/widgets/message/image_preview_page_test.dart