Skip to content

feat: fast unicode path - #69

Merged
stephantul merged 3 commits into
mainfrom
fast-unicode
Oct 28, 2026
Merged

stephantul merged 3 commits into
mainfrom
fast-unicode

Conversation

@stephantul

Copy link
Copy Markdown
Contributor

This PR adds a fast unicode path that improves performance on mixed and largely unicode text.

@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The main effect reaches text encoding for supported WordPiece models.

The PR appears safe to merge, with non-blocking improvements needed in the tests and empty-corpus checks.

Reviews (1) · Last reviewed commit: "feat: fast unicode path" · Reviewed by Greptile

Comment thread src/fast_wordpiece.rs Resolved
Comment thread scripts/bench_compare.py Resolved
@stephantul
stephantul merged commit e6d23d2 into main Oct 28, 2026
5 checks passed
@stephantul
stephantul deleted the fast-unicode branch October 28, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant