Introduce abstractions over IModFile#12
Open
marchermans wants to merge 2 commits intoMinecraftForge:masterfrom
Open
Introduce abstractions over IModFile#12marchermans wants to merge 2 commits intoMinecraftForge:masterfrom
IModFile#12marchermans wants to merge 2 commits intoMinecraftForge:masterfrom
Conversation
Removes a bunch of casts in forge and allows JIJ to work much more smoothly.
Contributor
|
As discussed on discord I think this approach is excessive and seriously complicates what are supposed to be pretty simple data holding objects.. |
cpw
suggested changes
Jun 14, 2022
Contributor
cpw
left a comment
cpw
left a comment
There was a problem hiding this comment.
There's a better way than this giant decomposition. I'd like to discuss on discord.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduced interfaces will be used in conjuction with the JiJ infrastructure to provide a better handling of the loading stages inside of forge it self.
Each added interface, more or less, represents a loading stage inside of forge and is used to handle it there in particularly. Up untill this PR loading infrastructure needed a harddep on either forge or fmlloader to gain access to classes like
ModFilewhich was required since casts where performed in between to gain access to isolated data which was only available inside ofModFilewith this PR in place we one step closer to a more isolated loading process.