Open
Conversation
wailbentafat
commented
Mar 27, 2026
Collaborator
Author
There was a problem hiding this comment.
hhh why u hav removed embed and compute evens?
| logger.warning("Missing image_ref in event payload for photo %s", job.photo_id) | ||
| return | ||
|
|
||
| embedding_literal = self._vector_literal(embedding) |
Collaborator
Author
There was a problem hiding this comment.
this two function make them as flat logique embedding_literal = self._vector_literal(embeddi bbox_payload = self._serialize_bbox(bbox) remove them and replace them with flat logique
| matched_user: ClosestUserMatch | None = None | ||
|
|
||
| try: | ||
| async with self.conn.begin(): |
Collaborator
Author
There was a problem hiding this comment.
also remove those two function and raplce them. with flat logiqure no neeed for helper fucntions
| raw = job.image_ref[len(MINIO_URL_PREFIX) :] | ||
| parts = raw.split("/", 1) | ||
| if len(parts) != 2 or not parts[0] or not parts[1]: | ||
| raise ValueError("Invalid MinIO image_ref format") |
Collaborator
Author
There was a problem hiding this comment.
u will get storage key not minio url try to read the content of the class before start vibe codding
Collaborator
Author
|
i will handle this code from here until the our next meeting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr introcduce some fixes for the worker code