fix: sign transaction and sign auth entry layout - #172
Merged
Conversation
| | 'boolean' | ||
| | 'json'; | ||
| | 'json' | ||
| | 'copyable'; |
Collaborator
Author
There was a problem hiding this comment.
add new type for UI to recognize and display copyable text
| {translate('confirmation.signAuthEntry.contract')} | ||
| </SnapText> | ||
| <Address address={`${scope}:${contractAddress}`} truncate /> | ||
| <Copyable value={contractAddress} /> |
Collaborator
Author
There was a problem hiding this comment.
Address field is trimmed, for visibility use Copyable
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Soroban signing confirmations in the Snap by decoding contract identifiers/arguments into human-readable strings and adjusting the confirmation UI layout to better handle long values (addresses, i128/u128, etc.), with copy-to-clipboard support.
Changes:
- Added shared XDR helpers to decode
ScAddress, contract function names, andScValarguments into readable display strings (with base64 fallback). - Updated operation/auth-entry mapping and confirmation UIs to render contract addresses and arguments in a copyable, labeled layout.
- Updated i18n strings and expanded test coverage for the new decoding and mapping behavior.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/snap/src/ui/confirmation/views/ConfirmSignTransaction/ConfirmSignTransaction.tsx | Renders JSON/argument arrays as labeled, Copyable rows and adds a copyable param type. |
| packages/snap/src/ui/confirmation/views/ConfirmSignAuthEntry/ConfirmSignAuthEntry.tsx | Switches contract/args display to a vertical layout with labeled, Copyable argument rows. |
| packages/snap/src/services/transaction/xdrParser.ts | Adds getAddress, getFunctionName, and readable ScVal decoding helpers used across the codebase. |
| packages/snap/src/services/transaction/xdrParser.test.ts | Adds tests for the new XDR decoding helpers and fallback behavior. |
| packages/snap/src/services/transaction/OperationMapper.ts | Uses new XDR helpers; maps contract address as copyable and arguments as readable strings. |
| packages/snap/src/services/transaction/OperationMapper.test.ts | Updates/extends mapping expectations for contract address + readable arguments. |
| packages/snap/src/services/network/NetworkService.ts | Reuses getAddress for contract address decoding. |
| packages/snap/src/handlers/keyring/signAuthEntry.ts | Reuses new XDR helpers for readable invocation summaries (function name, args, contract address). |
| packages/snap/src/handlers/keyring/signAuthEntry.test.ts | Updates expected readable args (now plain display strings). |
| packages/snap/messages.json | Updates labels (“Contract Address”) and adds per-argument label strings. |
| packages/snap/locales/es.json | Aligns locale metadata and updated/added strings with the new labels. |
| packages/snap/locales/en.json | Updates/adds strings for the new labels and per-argument rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maxime-oe
approved these changes
Jul 31, 2026
Julink-eth
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fix the contract address and argument display in sign transaction and sign auth entry dialog
Sign Transaction

Sign Auth Entry

References
Checklist