Skip to content

Implement Keyring API v2 #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremytsng wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement Keyring API v2 #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
},
"resolutions": {
"@metamask/snaps-sdk": "11.1.1",
"@metamask/snaps-utils": "12.2.0",

@stanleyyconsensys stanleyyconsensys Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not under resolution, or there are some special reason?

"@stellar/stellar-sdk/axios@npm:1.14.0": "1.18.1",
"axios/form-data@npm:^4.0.5": "^4.0.6",
"@metamask/snaps-utils/fast-xml-parser@npm:^5.3.4": "^5.7.0",
Expand Down
12 changes: 10 additions & 2 deletions packages/snap/snap.manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/MetaMask/snap-stellar-wallet.git"
},
"source": {
"shasum": "1ftcq5ewpbXIRZpVifhbpo4kHtdvXB4MEoo+bgjMWGQ=",
"shasum": "R5GFkwtIWH9mNc989eLsAxLU+12Ffd2JR/N1Sqatirw=",
"location": {
"npm": {
"filePath": "dist/bundle.js",
Expand All @@ -23,7 +23,15 @@
},
"initialPermissions": {
"endowment:keyring": {
"allowedOrigins": ["https://portfolio.metamask.io"]
"allowedOrigins": ["https://portfolio.metamask.io"],
"capabilities": {
"scopes": ["stellar:pubnet"],
"bip44": {
"deriveIndex": true,
"deriveIndexRange": true,
"discover": true
}
}
},
"snap_getBip32Entropy": [
{
Expand Down
22 changes: 0 additions & 22 deletions packages/snap/src/handlers/keyring/exceptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import {
TransactionValidationException,
} from '../../services/transaction/exceptions';
import { HttpException } from '../../utils';
import type { StellarSnapExceptionOptions } from '../../utils/errors';
import { StellarSnapException } from '../../utils/errors';

export class KeyringException extends StellarSnapException {}
Expand Down Expand Up @@ -131,24 +130,3 @@ export function toSep43Error(error: unknown): Sep43Error {

return new Sep43Error({ code: Sep43ErrorCode.Internal });
}

export class KeyringAccountRollbackException extends KeyringException {
constructor(accountId: string, options?: StellarSnapExceptionOptions) {
super(
`Failed to rollback account creation for account ${accountId}`,
options,
);
}
}

export class KeyringEmitAccountCreatedEventException extends KeyringException {
constructor(options?: StellarSnapExceptionOptions) {
super('Failed to emit account created event', options);
}
}

export class KeyringEmitAccountDeletedEventException extends KeyringException {
constructor(options?: StellarSnapExceptionOptions) {
super('Failed to emit account deleted event', options);
}
}
Loading
Loading