Skip to content

chore: bump @metamask/network-enablement-controller - #34135

Open
mikesposito wants to merge 7 commits into
mainfrom
me/chore/bump-network-enablement-controller
Open

chore: bump @metamask/network-enablement-controller#34135
mikesposito wants to merge 7 commits into
mainfrom
me/chore/bump-network-enablement-controller

Conversation

@mikesposito

@mikesposito mikesposito commented Jul 31, 2026

Copy link
Copy Markdown
Member

Description

Bumping @metamask/network-enablement-controller to ^6.0.0

## [6.0.0]

### Added

- Expose missing public `NetworkEnablementController` method through its messenger ([#9660](https://github.com/MetaMask/core/pull/9660))
  - The following action is now available:
    - `NetworkEnablementController:restoreEnabledNetworkMap`
  - Corresponding action type (`NetworkEnablementControllerRestoreEnabledNetworkMapAction`) is available as well.

### Changed

- **BREAKING:** Popular-network classification is now augmented by `ConfigRegistryController` ([#9611](https://github.com/MetaMask/core/pull/9611))
  - `NetworkEnablementControllerMessenger` now requires the `ConfigRegistryController:getState` action to be available.
- Bump `@metamask/transaction-controller` from `^69.0.0` to `^69.3.0` ([#9568](https://github.com/MetaMask/core/pull/9568), [#9589](https://github.com/MetaMask/core/pull/9589), [#9593](https://github.com/MetaMask/core/pull/9593), [#9693](https://github.com/MetaMask/core/pull/9693))
- Bump `@metamask/keyring-api` from `^23.5.0` to `^23.7.0` ([#9676](https://github.com/MetaMask/core/pull/9676))
- Bump `@metamask/config-registry-controller` from `^0.4.1` to `^1.0.0` ([#9706](https://github.com/MetaMask/core/pull/9706))

Changelog

CHANGELOG entry: null

Related issues

Related: https://consensyssoftware.atlassian.net/browse/WPN-1710

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Popular-network enablement behavior changes via ConfigRegistryController integration (breaking in v6), which can affect which networks are treated as popular without the prior patch override.

Overview
Upgrades @metamask/network-enablement-controller from a 5.4.1 yarn patch to ^6.0.0 (resolved to 6.0.2) and removes the patch that only added Robinhood (4663) to the popular-networks list.

To satisfy the v6 breaking messenger contract, getNetworkEnablementControllerMessenger now delegates ConfigRegistryController:getState so popular-network classification can use config registry data instead of relying on the old patch.

Lockfile updates drop the patched package entry and align transitive deps (e.g. @metamask/config-registry-controller, updated transaction-controller / network-controller pins inside the controller).

Reviewed by Cursor Bugbot for commit 9b6ed05. Bugbot is set up for automated code reviews on this repo. Configure here.

@mikesposito
mikesposito requested a review from a team as a code owner July 31, 2026 11:42
@metamask-ci metamask-ci Bot added the team-core-platform Core Platform team label Jul 31, 2026
@metamask-ci

metamask-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.
  • Manual testing steps still contain template content (the Gherkin example title or a [...] placeholder). Replace with real steps, or write N/A — <reason>.
  • Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.
  • Pre-merge author checklist has unchecked items (e.g. "I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@socket-security

socket-security Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​config-registry-controller@​0.3.2 ⏵ 1.0.074 +110075 +195 +2100

View full report

@github-actions github-actions Bot added size-S risk:high AI analysis: high risk labels Jul 31, 2026
ulissesferreira
ulissesferreira previously approved these changes Aug 3, 2026
@mikesposito mikesposito added team-networks Networks team and removed team-core-platform Core Platform team labels Aug 4, 2026
ulissesferreira
ulissesferreira previously approved these changes Aug 4, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps, SmokeMMConnect
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/network-enablement-controller@npm:^5.4.1, @metamask/config-registry-controller, @metamask/network-enablement-controller. Running all tests.

Performance Test Selection:
The changes are focused on controller version upgrades and messenger configuration fixes. While these affect network enablement logic, they don't directly impact rendering performance, app launch times, or any of the specific performance scenarios covered by the available performance tags (AccountList, Onboarding, Login, Swaps, Launch, AssetLoading, Predict, Perps). No performance test files were changed.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

ulissesferreira
ulissesferreira previously approved these changes Aug 7, 2026
@ulissesferreira

Copy link
Copy Markdown
Contributor

Superseded by MetaMask/metamask-extension#45236

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2026
@mikesposito

Copy link
Copy Markdown
Member Author

@ulissesferreira the PR you linked is for Extension. Is there a PR for Mobile to bump these packages already?

@mikesposito mikesposito reopened this Aug 10, 2026
@mikesposito mikesposito changed the title chore: bump @metamask/{network-enablement, config-registry}-controller chore: bump @metamask/network-enablement-controller Aug 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk:high AI analysis: high risk size-S team-networks Networks team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants