refactor(delegation): remove duplicate messenger types

[Mrtenz]

Description

Applies the same messenger type refactoring from #31467 to the two delegation-owned messenger files (delegation-controller-messenger, gator-permissions-controller-messenger).

Narrows rootMessenger parameters to RootMessenger<AllowedActions, AllowedEvents>, simplifies new Messenger<Namespace, Actions, Events, Root>({…}) to typed variable declarations, converts DelegationControllerInitMessenger from ReturnType<typeof …> to an explicit Messenger<'DelegationControllerInit', never, Events> type, and adds an explicit return type to getDelegationControllerInitMessenger.

Also removes the export type { GatorPermissionsControllerMessenger } re-export from the gator-permissions messenger file (replacing RootExtendedMessenger with the narrowed RootMessenger<…>), and updates the init test to import the type directly from @metamask/gator-permissions-controller.

No runtime behaviour changes.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A

Manual testing steps

N/A — pure TypeScript refactoring, no runtime behaviour changes.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
• I've tested with a power user scenario
• I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[mm-token-exchange-service]

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

[Copilot]

✅ Ready to approve

The changes are type-only refactors consistent with existing messenger patterns, with only minor follow-up best-practice nits noted.

Note: this review does not count toward required approvals for merging.

Pull request overview

This PR applies the RootMessenger<AllowedActions, AllowedEvents> narrowing and related messenger typing cleanups (previously done in #31467) to the delegation-owned messenger modules, aiming to remove duplicate messenger type declarations and make init messenger types explicit/self-contained without changing runtime behavior.

Changes:

• Narrowed messenger factory parameters to RootMessenger<AllowedActions, AllowedEvents> and simplified new Messenger<...>({ ... }) usages to typed variable declarations.
• Converted DelegationControllerInitMessenger from a ReturnType<typeof ...> alias to an explicit Messenger<'DelegationControllerInit', never, ...> type and added an explicit return type to getDelegationControllerInitMessenger.
• Removed the GatorPermissionsControllerMessenger type re-export from the local messenger file and updated the init test to import the type directly from @metamask/gator-permissions-controller.

File summaries

File	Description
app/core/Engine/messengers/gator-permissions-controller-messenger/gator-permissions-controller-messenger.ts	Narrows the root messenger parameter typing and removes the local type re-export.
app/core/Engine/messengers/delegation/delegation-controller-messenger.ts	Applies the narrowed RootMessenger<...> pattern and makes the init messenger type and factory return type explicit.
app/core/Engine/controllers/gator-permissions-controller/gator-permissions-controller-init.test.ts	Updates imports to use the upstream GatorPermissionsControllerMessenger type rather than a local re-export.

Copilot's findings

• Files reviewed: 3/3 changed files
• Comments generated: 2

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.