chore(analytics): sweep saveDataRecording from bridge-controller test mocks

[NicolasMassart]

Description

Removes saveDataRecording: false from the inline build() return value in bridge-controller-init.test.ts. The field was stale after the legacy saveDataRecording chain was removed in N8 (#31256).

This is PR-D of 6 in the owner-scoped sequence finishing the legacy MetaMetrics migration (#26820). PRs A–E are parallel mock-sweeps; PR-F does the interface removal once all five merge.

Changelog

CHANGELOG entry: null

Related issues

Refs: #26820

Manual testing steps

N/A — test mock cleanup only; unit tests cover the changed file.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Low Risk
Test-only mock cleanup with no production or analytics runtime changes.

Overview
Removes the obsolete saveDataRecording: false field from the AnalyticsEventBuilder build() mock in bridge-controller-init.test.ts, aligning the test stub with AnalyticsTrackingEvent after the legacy saveDataRecording chain was dropped (N8 / #31256).

This is PR-D in the owner-scoped mock sweep ahead of removing the field from the analytics interface (#26820); runtime bridge init and metrics behavior are unchanged.

^{Reviewed by Cursor Bugbot for commit 263cde4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.38%. Comparing base (4e34bc5) to head (e259246).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #31994   +/-   ##
=======================================
  Coverage   83.37%   83.38%           
=======================================
  Files        5816     5819    +3     
  Lines      151922   151988   +66     
  Branches    35741    35748    +7     
=======================================
+ Hits       126662   126728   +66     
  Misses      16588    16588           
  Partials     8672     8672           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud