chore(assets-controller): bump to 12.0.0 - #45085
Closed
Kriys94 wants to merge 6 commits into
Closed
Conversation
Kriys94
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨💎 @MetaMask/metamask-assets (2 files, +7 -21)
🧪 @MetaMask/qa (1 files, +19 -0)
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Contributor
Author
|
@metamaskbot update-policies |
Contributor
|
LavaMoat validation failed but no policy diffs were produced (the validation job may have crashed before generating diffs). Failed jobs: |
Contributor
Author
|
@metamaskbot update-policies |
Contributor
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes |
mikesposito
reviewed
Jul 31, 2026
Contributor
Builds ready [b20932a]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
Builds ready [2631e9e]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 0 warn · 🔴 0 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
Member
|
@metamaskbot update-policies |
Contributor
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👀 lavamoat/webpack/mv2/beta/policy.json changes differ from lavamoat/webpack/mv2/main/policy.json changes |
Contributor
Builds ready [f2afa97]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 10 warn · 🔴 1 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
|
Contributor
Builds ready [4f4f94a]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 12 warn · 🔴 1 fail)
Bundle size diffs [🚀 Bundle size reduced!]
|
ulissesferreira
approved these changes
Aug 7, 2026
ulissesferreira
added a commit
that referenced
this pull request
Aug 7, 2026
Contributor
|
Bump already happening in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches how token balances refresh and subscribe to backend activity (messenger surface change on a major assets-controller bump), which can affect send UI and post-transaction balance accuracy if wiring is wrong.
Overview
Upgrades
@metamask/assets-controllerto 12.0.0 and updates extension messenger wiring so the controller matches the new package expectations.AssetsController no longer delegates
BackendWebSocketServiceactions orconnectionStateChanged; real-time balance and connectivity are wired throughAccountActivityService:balanceUpdated(unchanged) plus the newAccountActivityService:statusChangedevent. Unit tests forgetAssetsControllerMessengerwere updated to match.E2E
SendPagegainscheckAvailableBalance, which polls the send amount screen until the displayed available balance matches an expected numeric value (15s timeout), supporting flows where balances update asynchronously after the v12 integration.Reviewed by Cursor Bugbot for commit 4f4f94a. Bugbot is set up for automated code reviews on this repo. Configure here.