fix: silence Sass deprecation warnings - #44727
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (2 files, +14 -12)
🫰 @MetaMask/core-platform (1 files, +1 -1)
👨🔧 @MetaMask/extension-platform (2 files, +27 -23)
📜 @MetaMask/policy-reviewers (1 files, +2 -1)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 👨🔧 @itsyoboieltr (2 files, +27 -23)
|
Contributor
Builds ready [3c6b035]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 6 warn · 🔴 2 fail)
Bundle size diffs
|
…ngs' into david/fix-sass-deprecation-warnings
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
@metamaskbot update-policies |
Contributor
|
Policies updated. Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. ✅ lavamoat/webpack/mv2/beta/policy.json changes match lavamoat/webpack/mv2/main/policy.json changes |
Contributor
Builds ready [94bfcc0]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 8 warn · 🔴 1 fail)
Bundle size diffs
|
Contributor
Builds ready [48cfc38]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 10 warn · 🔴 1 fail)
Bundle size diffs
|
Contributor
Builds ready [48cfc38]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 10 warn · 🔴 1 fail)
Bundle size diffs
|
DDDDDanica
approved these changes
Aug 3, 2026
HowardBraham
approved these changes
Aug 3, 2026
Contributor
Builds ready [48cfc38]
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 10 warn · 🔴 1 fail)
Bundle size diffs
|
Contributor
LavaMoat grants — sass-loader 14.1.1 → 17.0.0 ( Three grants in the hand-written override are unreferenced after this bump, and the new
Those three do not come from the generator: they are an explicit The four files Suggested change to "sass-loader": {
"builtin": {
- "url": true,
- "path": true,
- "util": true
+ "node:url.fileURLToPath": true,
+ "node:url.pathToFileURL": true,
+ "node:url": false
},
"packages": {
"sass-embedded": true
},
Removed by this bump: |
MajorLift
approved these changes
Aug 4, 2026
davidmurdoch
enabled auto-merge
August 5, 2026 20:05
FrederikBolding
approved these changes
Aug 6, 2026
ameliejyc
approved these changes
Aug 6, 2026
itsyoboieltr
approved these changes
Aug 6, 2026
|
Contributor
Builds ready [70abd7e]
⚡ Performance Benchmarks (Total: 🟢 11 pass · 🟡 13 warn · 🔴 0 fail)
Bundle size diffs
|
metamaskbot
added
the
release-13.45.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The upgrade from
sass-embedded1.71.0 to 1.100.0 caused the development webpack build to emit hundreds of Sass deprecation warnings from application and dependency stylesheets.This change:
sass-loaderfrom 14.1.1 to 17.0.0 and explicitly selects the reusable Sass Embeddedmodern-compilerAPIsass-loaderoptions levelquietDeps@importwarning, linked to the follow-up migration issueif()syntaxThe development build and a stylesheet-triggered incremental rebuild complete without Sass deprecation warnings.
Changelog
CHANGELOG entry: null
Related issues
Related to #44725
Manual testing steps
yarn start.Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Touches all SCSS compilation paths (dev, LavaMoat production, Storybook, integration CSS); misconfiguration could break builds or subtly change compiled CSS, though SCSS edits are small compatibility fixes.
Overview
Stops noisy Sass deprecation output after the
sass-embeddedbump by upgradingsass-loaderto 17 and aligning Storybook, main webpack, and integration-test webpack on the same Sass Embeddedmodern-compilersetup.Build configs now pass
sass-embeddedexplicitly (for LavaMoat-friendly resolution), keepwebpackImporter: false, renameincludePaths→loadPaths, and addquietDepsplus temporarysilenceDeprecations: ['import'](tracked in #44725). Integration tests usestyle: 'compressed'instead of deprecatedoutputStyle.First-party SCSS is updated for newer Sass:
map-get→map.getin typography, modernif()syntax infonts.scss, and a whitespace fix in a Snap UI disabled-state selector. LavaMoat policy dropsneo-asyncfromsass-loaderand allowsnode:path/node:url.Reviewed by Cursor Bugbot for commit 70abd7e. Bugbot is set up for automated code reviews on this repo. Configure here.