[DO NOT MERGE] bisect: main + v10 scuttle-exception additions only - #44585
Closed
MajorLift wants to merge 1 commit into
Closed
[DO NOT MERGE] bisect: main + v10 scuttle-exception additions only#44585MajorLift wants to merge 1 commit into
MajorLift wants to merge 1 commit into
Conversation
… branch `WebAssembly`, `Request`, and `requestIdleCallback` added to the scuttling exception list on plain main — isolates the branch's sole LavamoatPlugin change from the SDK upgrade. Do not merge.
MajorLift
added
the
no-changelog
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/extension-platform (1 files, +5 -0)
👨🔧 @itsyoboieltr (1 files, +5 -0)
|
|
Contributor
Builds ready [632f27e]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 9 warn · 🔴 0 fail)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bisect arm B for the
import-custom-token-with-custom-networkstall on #42867 (webpack-only, CI-only; spec is new on main as of #43821).This branch is plain main plus exactly one change: the v10 branch's three scuttling-exception additions (
WebAssembly,Request,requestIdleCallback) inLavamoatPlugin/index.ts. The spec's webpack shard here answers whether that build-layer change alone triggers the stall, with zero Sentry-SDK involvement.Requestflipping feature detection in fetch middleware); fundamental fix = scope or drop the exceptions.Will be closed after one CI cycle; results recorded on #42867.