refactor(analytics): migrate settings thunk MetaMetrics events#44379
Merged
gauthierpetetin merged 1 commit intoJul 14, 2026
Merged
Conversation
Part of analytics migration umbrella #43885 (15g · Settings Redux thunks).
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:07 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
36 tasks
|
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [cdabb3b]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 8 warn · 🔴 1 fail)
Bundle sizes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates two Settings-related Redux thunks from legacy trackMetaMetricsEvent usage to the newer analytics event builder (createEventBuilder) and trackAnalyticsEvent, aligning with the broader AnalyticsController migration effort.
Changes:
- Replaces
trackMetaMetricsEventpayload objects withcreateEventBuilder(...).addCategory(...).addProperties(...).build()for settings-updated events. - Updates imports to pull in
createEventBuilderalongside analytics event types.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gauthierpetetin
marked this pull request as ready for review
July 13, 2026 12:17
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 12:17 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
gauthierpetetin
enabled auto-merge
July 13, 2026 12:18
DDDDDanica
approved these changes
Jul 13, 2026
HowardBraham
approved these changes
Jul 14, 2026
gauthierpetetin
deleted the
refactor/analytics-migrate-orphan-settings-actions
branch
July 14, 2026 01:57
metamaskbot
added
the
release-13.41.0
DDDDDanica
pushed a commit
that referenced
this pull request
Jul 14, 2026
## **Description** Migrates remaining legacy `MetaMetricsContext.trackEvent` / `trackMetaMetricsEvent` call sites in the **Settings (smart account suggestion and smart transactions opt-in thunks)** domain to `useAnalytics()` + `createEventBuilder` (or `trackAnalyticsEvent` for Redux thunks). Part of umbrella tracker #43885 (**15g · Settings Redux thunks**). ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Build and load the extension (`yarn start`). 2. Exercise the flows touched by this PR (see changed files). 3. With MetaMetrics debug enabled, confirm events still fire with the same names and properties. <!-- ## **Screenshots/Recordings** ### **Before** ### **After** --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Mechanical telemetry refactor with unchanged event names and properties; preference dispatch logic is untouched. > > **Overview** > Continues the analytics migration in **Settings Redux thunks** by replacing legacy `trackMetaMetricsEvent` payloads with `trackAnalyticsEvent` + `createEventBuilder` in `ui/store/actions.ts`. > > **`setDismissSmartAccountSuggestionEnabled`** and **`setSmartTransactionsPreferenceEnabled`** still emit `SettingsUpdated` under the Settings category with the same property keys (`dismiss_smt_acc_suggestion_enabled` / `prev_*` and `stx_opt_in` / `prev_stx_opt_in`); only the construction path changes. The file now imports `createEventBuilder` (not just types) from `shared/lib/analytics/create-event-builder`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit cdabb3b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates remaining legacy
MetaMetricsContext.trackEvent/trackMetaMetricsEventcall sites in the Settings (smart account suggestion and smart transactions opt-in thunks) domain touseAnalytics()+createEventBuilder(ortrackAnalyticsEventfor Redux thunks).Part of umbrella tracker #43885 (15g · Settings Redux thunks).
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
yarn start).Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Mechanical telemetry refactor with unchanged event names and properties; preference dispatch logic is untouched.
Overview
Continues the analytics migration in Settings Redux thunks by replacing legacy
trackMetaMetricsEventpayloads withtrackAnalyticsEvent+createEventBuilderinui/store/actions.ts.setDismissSmartAccountSuggestionEnabledandsetSmartTransactionsPreferenceEnabledstill emitSettingsUpdatedunder the Settings category with the same property keys (dismiss_smt_acc_suggestion_enabled/prev_*andstx_opt_in/prev_stx_opt_in); only the construction path changes. The file now importscreateEventBuilder(not just types) fromshared/lib/analytics/create-event-builder.Reviewed by Cursor Bugbot for commit cdabb3b. Bugbot is set up for automated code reviews on this repo. Configure here.