refactor(analytics): migrate orphan platform metrics UI events#44378
Merged
gauthierpetetin merged 2 commits intoJul 14, 2026
Conversation
Part of analytics migration umbrella #43885 (15e · Platform metrics UI).
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:07 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
36 tasks
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [dd0eb16]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 6 warn · 🔴 1 fail)
Bundle sizes
|
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Drop useABTest from this PR to avoid changing experiment exposure semantics. Add parity assertions for migrated toggle and deletion events, and make the analytics action mock return a resolved promise. Co-authored-by: Cursor <cursoragent@cursor.com>
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 09:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 10:17 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [1e1609b]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 7 warn · 🔴 1 fail)
Bundle sizes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the MetaMetrics → Analytics migration by moving remaining “Platform metrics UI” event tracking call sites from legacy MetaMetricsContext.trackEvent usage to the newer useAnalytics() hook and createEventBuilder API, while updating unit tests and Jest action mocks accordingly.
Changes:
- Migrated UI components to
useAnalytics()+createEventBuilderfor MetaMetrics opt-in/out and data deletion events. - Updated unit tests to mock
useAnalytics()and assert the new built event payload shape. - Extended the Jest actions manual mock to include
trackAnalyticsEventto supportuseAnalytics-driven code paths in tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/components/app/metametrics-toggle/metametrics-toggle.tsx | Replaces MetaMetricsContext usage with useAnalytics() and event-builder-based tracking for opt-in/out events. |
| ui/components/app/metametrics-toggle/metametrics-toggle.test.tsx | Adds useAnalytics mocking and asserts the built analytics event payloads for toggle flows. |
| ui/components/app/delete-metametrics-data-button/delete-metametrics-data-button.test.tsx | Mocks useAnalytics() and resets tracking mock state to keep tests isolated from analytics implementation. |
| ui/components/app/clear-metametrics-data/clear-metametrics-data.tsx | Switches data deletion success/error tracking to builder events (including excludeMetaMetricsId options). |
| ui/components/app/clear-metametrics-data/clear-metametrics-data.test.tsx | Adds useAnalytics mocking and validates deletion/error events including options payload. |
| ui/mocks/actions.js | Adds a trackAnalyticsEvent stub to the actions manual mock to support useAnalytics call sites during tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gauthierpetetin
marked this pull request as ready for review
July 13, 2026 11:30
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 11:30 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
gauthierpetetin
enabled auto-merge
July 13, 2026 11:30
DDDDDanica
approved these changes
Jul 13, 2026
HowardBraham
approved these changes
Jul 14, 2026
gauthierpetetin
deleted the
refactor/analytics-migrate-orphan-platform-ui
branch
July 14, 2026 01:57
metamaskbot
added
the
release-13.41.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates remaining legacy
MetaMetricsContext.trackEvent/trackMetaMetricsEventcall sites in the Platform (metametrics toggle, clear data, A/B test hook) domain touseAnalytics()+createEventBuilder(ortrackAnalyticsEventfor Redux thunks).Part of umbrella tracker #43885 (15e · Platform metrics UI).
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
yarn start).Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Refactor-only analytics instrumentation with tests locking event shape; no changes to metrics opt-in, deletion tasks, or user data handling behavior.
Overview
Platform settings analytics in the clear-metrics modal and participate-in-metrics toggle now go through
useAnalytics()andcreateEventBuilderinstead ofMetaMetricsContext.trackEvent. Event names, categories, properties, and options such asexcludeMetaMetricsIdon deletion flows are unchanged—only the wiring API differs.Tests mock
useAnalyticsand assert the built event payloads for enable/disable toggles, deletion requests, and deletion failures. The shared actions mock adds a no-optrackAnalyticsEventfor Redux/thunk callers.Reviewed by Cursor Bugbot for commit 1e1609b. Bugbot is set up for automated code reviews on this repo. Configure here.