refactor(analytics): migrate orphan Web3Auth onboarding events#44377
Merged
gauthierpetetin merged 3 commits intoJul 13, 2026
Conversation
Part of analytics migration umbrella #43885 (15d · Web3Auth onboarding gaps).
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:06 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔐 @MetaMask/web3auth (2 files, +113 -35)
|
36 tasks
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:33 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [6a2cbca]
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 7 warn · 🔴 0 fail)
Bundle sizes
|
…tests Mock useAnalytics in reveal-recovery-phrase tests to avoid useSegmentContext errors with the partial react-router-dom mock, and apply oxfmt formatting. Co-authored-by: Cursor <cursoragent@cursor.com>
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 09:17 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates remaining legacy MetaMetrics UI call sites in the Web3Auth onboarding domain (SRP reveal, passkey troubleshooting, marketing consent, change-password, basic configuration) to the newer useAnalytics() + createEventBuilder tracking API, aligning these flows with the ongoing analytics refactor effort.
Changes:
- Replaced
MetaMetricsContext.trackEventusage withuseAnalytics().trackEvent(createEventBuilder(...).build())across several onboarding-related UI components. - Updated SRP reveal unit tests to mock
useAnalytics(to avoid real analytics wiring during tests). - Updated the passkey troubleshoot modal support-link tracking to explicitly include page-title context via
useSegmentContext.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/pages/onboarding-flow/recovery-phrase/reveal-recovery-phrase.tsx | Migrates SRP export tracking events to useAnalytics + event builder. |
| ui/pages/onboarding-flow/recovery-phrase/reveal-recovery-phrase.test.tsx | Mocks useAnalytics for SRP reveal tests. |
| ui/components/app/passkey-troubleshoot-modal/passkey-troubleshoot-modal.tsx | Migrates modal view/CTA/support-link events to event builder; injects page title via segment context. |
| ui/components/app/metametrics-consent/metametrics-consent-container.tsx | Migrates marketing consent selection tracking to event builder. |
| ui/components/app/change-password/change-password.tsx | Migrates passkey/password change analytics events to event builder. |
| ui/components/app/basic-configuration-modal/basic-configuration-modal.tsx | Migrates settings-updated tracking to event builder for onboarding vs settings contexts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 09:42 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [a6e4068]
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 0 fail)
Bundle sizes
|
Mock useAnalytics in basic-configuration-modal tests to avoid background connection console warnings, and assert SRP export analytics events in reveal-recovery-phrase tests. Co-authored-by: Cursor <cursoragent@cursor.com>
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 11:54 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 12:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [47b7b93]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 7 warn · 🔴 1 fail)
Bundle sizes
|
gauthierpetetin
marked this pull request as ready for review
July 13, 2026 12:19
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 12:20 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
gauthierpetetin
enabled auto-merge
July 13, 2026 12:30
lwin-kyaw
approved these changes
Jul 13, 2026
chaitanyapotti
approved these changes
Jul 13, 2026
metamaskbot
added
the
release-13.41.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates remaining legacy
MetaMetricsContext.trackEvent/trackMetaMetricsEventcall sites in the Web3Auth (recovery phrase, passkey, consent, password) domain touseAnalytics()+createEventBuilder(ortrackAnalyticsEventfor Redux thunks).Part of umbrella tracker #43885 (15d · Web3Auth onboarding gaps).
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
yarn start).Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Analytics instrumentation refactor only; no changes to wallet, auth, or password/passkey business logic beyond how events are emitted.
Overview
Replaces remaining
MetaMetricsContexttrackEventusage in Web3Auth-related UI (basic functionality modal, change password, marketing consent, passkey troubleshoot, reveal SRP) withuseAnalytics()andcreateEventBuilder().build(), keeping the same event names and properties.Passkey troubleshoot now pulls page title for support-link events from
useSegmentContextinstead of the legacy second-argument context merge.Tests for reveal recovery phrase (and related setup) mock
useAnalyticsand asserttrackEventreceives the built payload shape (name,properties,sensitiveProperties) on SRP export success and failure paths.Reviewed by Cursor Bugbot for commit 47b7b93. Bugbot is set up for automated code reviews on this repo. Configure here.