refactor(analytics): migrate orphan UX contacts and chrome events#44374
Merged
gauthierpetetin merged 5 commits intoJul 15, 2026
Merged
Conversation
Part of analytics migration umbrella #43885 (15a · UX contacts + chrome).
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:06 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +68 -63)
👨🔧 @MetaMask/core-extension-ux (2 files, +68 -63)
👨🔧 @MetaMask/product-safety (1 files, +11 -12)
|
Co-authored-by: Cursor <cursoragent@cursor.com>
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:07 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
36 tasks
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 05:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [c50fd4e]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 7 warn · 🔴 2 fail)
Bundle sizes
|
Co-authored-by: Cursor <cursoragent@cursor.com>
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 08:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the analytics migration by replacing remaining legacy MetaMetricsContext.trackEvent usage in UX “contacts + chrome” surfaces with the newer useAnalytics() hook and createEventBuilder event shape, and updates unit tests accordingly.
Changes:
- Migrated multiple UI components/pages from
MetaMetricsContexttouseAnalytics()+createEventBuilder(...)...build(). - Updated event payload construction to the new
{ name, properties, sensitiveProperties }format. - Refactored related Jest tests to mock
useAnalyticsand assert the new event shape.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/pages/contacts/contacts-list-page.tsx | Migrates contacts list page view/click events to useAnalytics + builder. |
| ui/pages/contacts/contact-details-page.tsx | Migrates contact details view/edit/delete events to builder format. |
| ui/pages/contacts/components/edit-contact-form.tsx | Migrates “contact updated” tracking to builder format. |
| ui/pages/contacts/components/add-contact-form.tsx | Migrates QR scanner + “contact added” tracking to builder format. |
| ui/components/ui/qr-code-view/qr-code-view.tsx | Migrates “public address copied” tracking to builder format. |
| ui/components/multichain/account-overview/carousel.tsx | Migrates banner display/select/dismiss tracking to builder format. |
| ui/components/multichain/account-overview/carousel.test.tsx | Updates carousel tests to mock useAnalytics + assert built event shape. |
| ui/components/app/update-modal/update-modal.tsx | Migrates force-upgrade modal tracking to builder format. |
| ui/components/app/update-modal/update-modal.test.tsx | Updates update-modal tests for useAnalytics + built event shape. |
| ui/components/app/terms-of-use-popup/terms-of-use-popup.js | Migrates terms-of-use “shown” tracking to builder format. |
| ui/components/app/terms-of-use-popup/terms-of-use-popup-container.tsx | Migrates terms-of-use “accepted” tracking to builder format. |
| ui/components/app/product-safety/scam-questionnaire/useScamQuestionnaireMetrics.ts | Migrates scam questionnaire metrics helper to use builder. |
| ui/components/app/permission-page-container/permission-page-container.component.js | Adapts permission page to accept legacy payloads and forward via builder. |
| ui/components/app/password-outdated-modal/password-outdated-modal.tsx | Migrates password-outdated modal “viewed” tracking to builder format. |
| ui/components/app/password-outdated-modal/password-outdated-modal.test.tsx | Updates password-outdated modal tests for useAnalytics + built event shape. |
| ui/components/app/multichain-transaction-details-modal/multichain-transaction-details-modal.tsx | Migrates external-link click tracking to builder format. |
| ui/components/app/multichain-transaction-details-modal/multichain-transaction-details-modal.test.tsx | Updates multichain transaction details modal tests for useAnalytics. |
| ui/components/app/modals/pna25-modal/pna25-modal.tsx | Migrates PNA25 notice tracking to builder format. |
| ui/components/app/modals/pna25-modal/pna25-modal.test.tsx | Updates PNA25 modal tests for useAnalytics + built event shape. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ckEvent Add hasTrackedView-style ref guards so mount and page-view metrics do not re-fire when useAnalytics trackEvent identity changes during metrics init. Co-authored-by: Cursor <cursoragent@cursor.com>
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 09:03 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
gauthierpetetin
marked this pull request as ready for review
July 13, 2026 09:15
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 09:16 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
gauthierpetetin
enabled auto-merge
July 13, 2026 09:16
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 09:30 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [c1f3db5]
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 8 warn · 🔴 0 fail)
Bundle sizes
|
gauthierpetetin
temporarily deployed
to
pr-comment
July 13, 2026 11:34 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [c1f3db5]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle sizes
|
ameliejyc
previously approved these changes
Jul 15, 2026
ccharly
previously approved these changes
Jul 15, 2026
ccharly
left a comment
ccharly
left a comment
Contributor
There was a problem hiding this comment.
LGTM for accounts:
ui/components/multichain/account-overview/carousel.test.tsx
ui/components/multichain/account-overview/carousel.tsx
AugmentedMode
previously approved these changes
Jul 15, 2026
…s-chrome Co-authored-by: Cursor <cursoragent@cursor.com>
gauthierpetetin
dismissed stale reviews from AugmentedMode, ccharly, and ameliejyc
via
July 15, 2026 19:13
9a011e4
gauthierpetetin
temporarily deployed
to
pr-comment
July 15, 2026 19:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
|
gauthierpetetin
temporarily deployed
to
pr-comment
July 15, 2026 19:40 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Builds ready [9a011e4]
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 8 warn · 🔴 0 fail)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
AugmentedMode
approved these changes
Jul 15, 2026
owencraston
approved these changes
Jul 15, 2026
gauthierpetetin
deleted the
refactor/analytics-migrate-orphan-ux-contacts-chrome
branch
July 15, 2026 22:27
metamaskbot
added
the
release-13.41.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates remaining legacy
MetaMetricsContext.trackEvent/trackMetaMetricsEventcall sites in the UX (contacts, modals, carousel, permission page) domain touseAnalytics()+createEventBuilder(ortrackAnalyticsEventfor Redux thunks).Part of umbrella tracker #43885 (15a · UX contacts + chrome).
Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
yarn start).Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Mechanical analytics API migration with test coverage updates; contact events still use sensitive properties for addresses, and view dedupe refs reduce duplicate metrics rather than changing product behavior.
Overview
This PR finishes migrating UX “chrome” surfaces (contacts, modals, carousel, permission connect, QR copy, scam questionnaire) from legacy
MetaMetricsContext.trackEventtouseAnalytics()withcreateEventBuilder(...).build(), aligning payloads with the shared analytics shape (name,properties,sensitiveProperties).Production code swaps
useContext(MetaMetricsContext)for the hook and rebuilds each event via the builder (categories, properties, and contact-relatedaddSensitivePropertieswhere addresses are sent).PermissionPageContainerwraps the hook in a small adapter so the base component still receives a legacy-shapedtrackEventcallback. Several mount/view effects gain refs so impressions are not double-fired when dependencies re-run (password outdated, terms of use, force-upgrade modal, contacts list/details).Tests drop
MetaMetricsContext.Providerwrappers in favor ofjest.mock('.../useAnalytics')using the realcreateEventBuilder, and assertions are updated to the built event object.Reviewed by Cursor Bugbot for commit 9a011e4. Bugbot is set up for automated code reviews on this repo. Configure here.