Skip to content

refactor(analytics): migrate accounts hardware wallet events#43895

Merged
gauthierpetetin merged 9 commits into
mainfrom
refactor/analytics-migrate-accounts-hardware
Jul 8, 2026
Merged

refactor(analytics): migrate accounts hardware wallet events#43895
gauthierpetetin merged 9 commits into
mainfrom
refactor/analytics-migrate-accounts-hardware

Conversation

@gauthierpetetin

@gauthierpetetin gauthierpetetin commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Sub-PR of umbrella tracker #43885.

Migrates MetaMetrics trackEvent call sites in this CODEOWNERS domain to createEventBuilder + trackEvent via useAnalytics() (UI) or app/scripts/controllers/analytics (background).

Dependency note: Can merge in parallel with other domain PRs after PR1.

Files in this PR: 25

Changelog

CHANGELOG entry: null

Related issues

Part of analytics migration umbrella: #43885

Manual testing steps

  1. Check out this branch and run yarn start.
  2. Exercise flows in the touched domain (see diff file list).
  3. Confirm no console errors and representative events still fire.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches many hardware-wallet and confirmation analytics paths; event shape changes (name vs event, category in properties) could affect Segment payloads if downstream consumers assumed the old MetaMetrics object shape.

Overview
Migrates accounts / hardware wallet MetaMetrics call sites from MetaMetricsContext to useAnalytics() with createEventBuildertrackEvent, aligned with the umbrella analytics migration.

Hardware recovery & QR flows (HardwareWalletErrorModal, BaseQrReader, QR utils) now build events via the shared builder instead of plain { category, event, properties } objects; helpers like buildQrCameraRecoveryTrackEventArgs return AnalyticsEvent (name + properties, with category on properties). Connect hardware pages and inline recovery CTAs (bridge footer, confirmation reconnect, trackHardwareWalletRecoveryConnectCtaClicked) follow the same pattern; connect-CTA tracking uses try/catch instead of .catch() on a promise.

Tests & Storybook drop MetaMetricsContext wrappers and jest.mock useAnalytics (often with real createEventBuilder); assertions switch from call[0].event to call[0].name. .storybook/main.js adds/adjusts webpack aliases so Storybook resolves useAnalytics mocks.

Reviewed by Cursor Bugbot for commit f9ca58f. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamask-ci

metamask-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (8 files, +163 -125)
  • 📁 ui/
    • 📁 contexts/
      • 📁 hardware-wallets/
        • 📄 useHardwareWalletMetrics.test.tsx +16 -18
        • 📄 useHardwareWalletMetrics.ts +3 -3
    • 📁 pages/
      • 📁 create-account/
        • 📁 connect-hardware/
          • 📄 account-list.tsx +24 -20
          • 📄 index.test.tsx +15 -0
          • 📄 index.tsx +73 -60
          • 📄 select-hardware.stories.tsx +3 -13
          • 📄 select-hardware.test.tsx +15 -0
          • 📄 select-hardware.tsx +14 -11

@MetaMask/confirmations (1 files, +16 -4)
  • 📁 ui/
    • 📁 pages/
      • 📁 confirmations/
        • 📁 components/
          • 📁 confirm/
            • 📁 footer/
              • 📄 footer.test.tsx +16 -4

🔄 @MetaMask/swaps-engineers (2 files, +19 -5)
  • 📁 ui/
    • 📁 pages/
      • 📁 bridge/
        • 📁 prepare/
          • 📄 bridge-cta-button.test.tsx +16 -2
          • 📄 bridge-cta-button.tsx +3 -3

@metamask-ci

metamask-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f0e5f34]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 13 pass · 🟡 11 warn · 🔴 0 fail)

Baseline (latest main): d50b2dc | Date: 6/25/2026 | Pipeline: 28177720346 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • confirmTx/tbt: +12%
  • bridgeUserActions/bridge_load_asset_picker: +21%
  • bridgeUserActions/longTaskCount: +43%
  • bridgeUserActions/longTaskTotalDuration: +35%
  • bridgeUserActions/inp: +70%
  • bridgeUserActions/lcp: +10%
  • loadNewAccount/inp: -19%
  • loadNewAccount/fcp: -48%
  • loadNewAccount/lcp: +1055%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/inp: -12%
  • confirmTx/fcp: -49%
  • confirmTx/lcp: +1129%
  • bridgeUserActions/bridge_load_page: +136%
  • bridgeUserActions/bridge_load_asset_picker: +26%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +20%
  • bridgeUserActions/inp: +60%
  • bridgeUserActions/fcp: -44%
  • bridgeUserActions/lcp: +1208%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.8s
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 loadScripts
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupPowerUserHome/domInteractive: +31%
  • startupPowerUserHome/backgroundConnect: -16%
  • startupPowerUserHome/fcp: +29%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 3.7s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/pwFormToMetricsScreen: +10%
  • onboardingImportWallet/metricsToWalletReadyScreen: -12%
  • onboardingImportWallet/doneButtonToHomeScreen: -84%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -93%
  • onboardingImportWallet/longTaskCount: -77%
  • onboardingImportWallet/longTaskTotalDuration: -92%
  • onboardingImportWallet/longTaskMaxDuration: -89%
  • onboardingImportWallet/tbt: -96%
  • onboardingImportWallet/total: -85%
  • onboardingNewWallet/doneButtonToAssetList: -17%
  • onboardingNewWallet/longTaskTotalDuration: -44%
  • onboardingNewWallet/longTaskMaxDuration: -30%
  • onboardingNewWallet/tbt: -57%
  • onboardingNewWallet/total: -16%
  • solanaAssetDetails/assetClickToPriceChart: -59%
  • solanaAssetDetails/total: -59%
  • solanaAssetDetails/lcp: -58%
  • importSrpHome/loginToHomeScreen: -18%
  • importSrpHome/openAccountMenuAfterLogin: +11%
  • importSrpHome/homeAfterImportWithNewWallet: -39%
  • importSrpHome/longTaskCount: -31%
  • importSrpHome/longTaskTotalDuration: -34%
  • importSrpHome/longTaskMaxDuration: -15%
  • importSrpHome/tbt: -39%
  • importSrpHome/total: -38%
  • importSrpHome/inp: -33%
  • importSrpHome/fcp: +22%
  • importSrpHome/cls: -73%
  • sendTransactions/openSendPageFromHome: -31%
  • sendTransactions/selectTokenToSendFormLoaded: +173%
  • sendTransactions/reviewTransactionToConfirmationPage: -14%
  • sendTransactions/longTaskCount: -25%
  • sendTransactions/longTaskTotalDuration: -43%
  • sendTransactions/longTaskMaxDuration: -29%
  • sendTransactions/tbt: -86%
  • sendTransactions/total: -12%
  • sendTransactions/inp: -19%
  • sendTransactions/lcp: -26%
  • sendTransactions/cls: -93%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/INP: p75 208ms
  • 🟡 importSrpHome/FCP: p75 2.2s
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 173 Bytes (0%)
  • ui: 340 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 2.4 KiB (0.01%)

@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from f0e5f34 to 666bb7a Compare June 26, 2026 03:55
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci

metamask-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
Builds ready [666bb7a]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 17 pass · 🟡 7 warn · 🔴 0 fail)

Baseline (latest main): 1e3d238 | Date: 6/25/2026 | Pipeline: 28216091459 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
🔴 bridge_load_asset_picker

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/inp: +11%
  • loadNewAccount/lcp: -21%
  • loadNewAccount/cls: -75%
  • bridgeUserActions/bridge_load_page: +32%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -24%
  • bridgeUserActions/tbt: -26%
  • loadNewAccount/load_new_account: +343%
  • loadNewAccount/total: +343%
  • loadNewAccount/inp: -21%
  • loadNewAccount/fcp: -55%
  • loadNewAccount/lcp: +953%
  • confirmTx/confirm_tx: +12%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +12%
  • confirmTx/inp: -22%
  • confirmTx/fcp: -51%
  • confirmTx/lcp: +1104%
  • bridgeUserActions/bridge_load_page: +180%
  • bridgeUserActions/bridge_load_asset_picker: +1427%
  • bridgeUserActions/bridge_search_token: +14%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +234%
  • bridgeUserActions/inp: -12%
  • bridgeUserActions/lcp: +1127%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/domInteractive: -15%
  • startupStandardHome/setupStore: -23%
  • startupStandardHome/fcp: -15%
  • startupPowerUserHome/backgroundConnect: -20%
  • startupPowerUserHome/setupStore: +25%
  • startupPowerUserHome/inp: +19%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 232ms
  • 🟡 startupPowerUserHome/LCP: p75 3.5s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: -12%
  • onboardingImportWallet/doneButtonToHomeScreen: -76%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -93%
  • onboardingImportWallet/longTaskCount: -75%
  • onboardingImportWallet/longTaskTotalDuration: -89%
  • onboardingImportWallet/longTaskMaxDuration: -88%
  • onboardingImportWallet/tbt: -97%
  • onboardingImportWallet/total: -80%
  • onboardingNewWallet/skipBackupToMetricsScreen: +14%
  • onboardingNewWallet/doneButtonToAssetList: -28%
  • onboardingNewWallet/longTaskCount: -62%
  • onboardingNewWallet/longTaskTotalDuration: -59%
  • onboardingNewWallet/longTaskMaxDuration: -32%
  • onboardingNewWallet/tbt: -63%
  • onboardingNewWallet/total: -21%
  • solanaAssetDetails/assetClickToPriceChart: -64%
  • solanaAssetDetails/total: -64%
  • solanaAssetDetails/cls: +12%
  • importSrpHome/openAccountMenuAfterLogin: +48%
  • importSrpHome/homeAfterImportWithNewWallet: -23%
  • importSrpHome/longTaskCount: -25%
  • importSrpHome/longTaskTotalDuration: -25%
  • importSrpHome/tbt: -29%
  • importSrpHome/total: -20%
  • importSrpHome/inp: -34%
  • importSrpHome/lcp: +20%
  • importSrpHome/cls: -53%
  • sendTransactions/openSendPageFromHome: +45%
  • sendTransactions/reviewTransactionToConfirmationPage: +13%
  • sendTransactions/longTaskCount: -50%
  • sendTransactions/longTaskTotalDuration: -61%
  • sendTransactions/longTaskMaxDuration: -39%
  • sendTransactions/tbt: -100%
  • sendTransactions/total: +13%
  • sendTransactions/inp: -17%
  • sendTransactions/lcp: +12%
  • sendTransactions/cls: -92%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs
  • background: 173 Bytes (0%)
  • ui: 340 Bytes (0%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 0 Bytes (0%)
  • zip: 2.43 KiB (0.01%)

@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from 666bb7a to 2e585bd Compare June 26, 2026 05:15
@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from 2e585bd to 9ee224b Compare June 26, 2026 05:29
@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from 9ee224b to 25de312 Compare June 26, 2026 06:02
@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from 25de312 to e5e573f Compare June 26, 2026 06:13
@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from e5e573f to 1cdc159 Compare June 26, 2026 06:18
@metamask-ci

metamask-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
Builds ready [1cdc159] [reused from 2e585bd]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 12 pass · 🟡 5 warn · 🔴 0 fail)

Baseline (latest main): 1e3d238 | Date: 6/25/2026 | Pipeline: 28220952819 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -55%
  • loadNewAccount/total: -55%
  • loadNewAccount/inp: -29%
  • loadNewAccount/fcp: -21%
  • loadNewAccount/lcp: -13%
  • loadNewAccount/cls: -75%
  • confirmTx/longTaskTotalDuration: -22%
  • confirmTx/longTaskMaxDuration: -18%
  • confirmTx/tbt: -41%
  • confirmTx/inp: +12%
  • confirmTx/fcp: -22%
  • bridgeUserActions/bridge_load_page: -12%
  • bridgeUserActions/bridge_load_asset_picker: -27%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -44%
  • bridgeUserActions/longTaskMaxDuration: -33%
  • bridgeUserActions/tbt: -88%
  • bridgeUserActions/inp: -22%
  • loadNewAccount/inp: -29%
  • loadNewAccount/lcp: +1055%
  • confirmTx/confirm_tx: +11%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +11%
  • confirmTx/inp: -14%
  • confirmTx/lcp: +1198%
  • bridgeUserActions/bridge_load_page: +249%
  • bridgeUserActions/bridge_load_asset_picker: +60%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +34%
  • bridgeUserActions/inp: +86%
  • bridgeUserActions/lcp: +1235%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
Startup Benchmarks · Samples: 100

⚠️ Missing data: firefox/webpack/startupStandardHome, firefox/webpack/startupPowerUserHome

Benchmarkchrome-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]
User Journey Benchmarks · Samples: 5 · mock API

⚠️ Missing data: chrome/webpack/userJourneyTransactions, firefox/webpack/userJourneyTransactions

Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -77%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -100%
  • onboardingImportWallet/longTaskCount: -50%
  • onboardingImportWallet/longTaskTotalDuration: -87%
  • onboardingImportWallet/longTaskMaxDuration: -84%
  • onboardingImportWallet/tbt: -93%
  • onboardingImportWallet/total: -82%
  • onboardingNewWallet/skipBackupToMetricsScreen: +11%
  • onboardingNewWallet/doneButtonToAssetList: -25%
  • onboardingNewWallet/longTaskCount: -23%
  • onboardingNewWallet/longTaskTotalDuration: -31%
  • onboardingNewWallet/longTaskMaxDuration: -18%
  • onboardingNewWallet/tbt: -45%
  • onboardingNewWallet/total: -22%
  • solanaAssetDetails/assetClickToPriceChart: -57%
  • solanaAssetDetails/total: -57%
  • solanaAssetDetails/cls: +12%
  • importSrpHome/loginToHomeScreen: -11%
  • importSrpHome/homeAfterImportWithNewWallet: -33%
  • importSrpHome/longTaskCount: -33%
  • importSrpHome/longTaskTotalDuration: -26%
  • importSrpHome/tbt: -30%
  • importSrpHome/total: -29%
  • importSrpHome/inp: -28%
  • importSrpHome/lcp: +11%
  • importSrpHome/cls: -53%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 assetDetails/INP: p75 736ms
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
Dapp Page Load Benchmarks · Samples: 100

⚠️ Missing data: chrome/webpack/pageLoadBenchmark

✅ No regressions detected

Bundle sizes
  • background: 10.75 MiB
  • ui: 16.87 MiB
  • common: 0 Bytes
  • other: 997.96 KiB
  • contentScripts: 1.79 MiB
  • zip: 26.13 MiB
No bundle-size baseline commit was available for this build, so diff values are omitted.

@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from 1cdc159 to 855f895 Compare June 26, 2026 07:20
@gauthierpetetin
gauthierpetetin force-pushed the refactor/analytics-migrate-accounts-hardware branch from 855f895 to 05305fe Compare June 26, 2026 08:00
gauthierpetetin and others added 3 commits July 1, 2026 13:25
Drop dual-path MetaMetricsContext compatibility and use the
createEventBuilder-based API only, matching other migration PRs.

Co-authored-by: Cursor <cursoragent@cursor.com>
Match the store/actions alias pattern so webpack resolves relative
useAnalytics imports to the Storybook mock at each import depth.

Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve useHardwareWalletMetrics.test.tsx conflict by keeping the
useAnalytics mock instead of the MetaMetricsContext wrapper from main.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
Builds ready [8dd5a15]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 10 warn · 🔴 0 fail)

Baseline (latest main): 1716549 | Date: 6/29/2026 | Pipeline: 28517416453 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -14%
  • loadNewAccount/total: -14%
  • loadNewAccount/inp: +15%
  • confirmTx/tbt: -11%
  • bridgeUserActions/bridge_load_page: -33%
  • bridgeUserActions/bridge_load_asset_picker: -32%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -23%
  • bridgeUserActions/longTaskMaxDuration: -14%
  • bridgeUserActions/tbt: -35%
  • bridgeUserActions/inp: +21%
  • loadNewAccount/load_new_account: +589%
  • loadNewAccount/total: +589%
  • loadNewAccount/inp: +121%
  • loadNewAccount/fcp: -60%
  • loadNewAccount/lcp: +1008%
  • confirmTx/confirm_tx: +12%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +12%
  • confirmTx/lcp: +1108%
  • bridgeUserActions/bridge_load_page: +220%
  • bridgeUserActions/bridge_load_asset_picker: +69%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +29%
  • bridgeUserActions/inp: +133%
  • bridgeUserActions/fcp: -46%
  • bridgeUserActions/lcp: +1143%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/INP: p75 216ms
  • 🟡 confirmTx/FCP: p75 1.8s
  • 🟡 bridgeUserActions/INP: p75 216ms
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/uiStartup: -17%
  • startupStandardHome/load: -17%
  • startupStandardHome/domContentLoaded: -17%
  • startupStandardHome/backgroundConnect: -17%
  • startupStandardHome/firstReactRender: -20%
  • startupStandardHome/initialActions: -33%
  • startupStandardHome/loadScripts: -17%
  • startupStandardHome/setupStore: -33%
  • startupStandardHome/longTaskCount: -33%
  • startupStandardHome/longTaskTotalDuration: -26%
  • startupStandardHome/longTaskMaxDuration: -20%
  • startupStandardHome/tbt: -24%
  • startupStandardHome/inp: -13%
  • startupStandardHome/fcp: -17%
  • startupStandardHome/lcp: -15%
  • startupPowerUserHome/initialActions: +33%
  • startupStandardHome/domInteractive: -23%
  • startupStandardHome/fcp: -22%
  • startupPowerUserHome/inp: +20%
  • startupPowerUserHome/fcp: +22%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🔴 startupPowerUserHome/INP: p75 544ms
  • 🟡 startupPowerUserHome/INP: p75 264ms
  • 🟡 startupPowerUserHome/LCP: p75 3.7s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/doneButtonToHomeScreen: -85%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -64%
  • onboardingImportWallet/longTaskCount: -80%
  • onboardingImportWallet/longTaskTotalDuration: -93%
  • onboardingImportWallet/longTaskMaxDuration: -90%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -84%
  • onboardingNewWallet/doneButtonToAssetList: -37%
  • onboardingNewWallet/longTaskCount: -50%
  • onboardingNewWallet/longTaskTotalDuration: -58%
  • onboardingNewWallet/longTaskMaxDuration: -22%
  • onboardingNewWallet/tbt: -47%
  • onboardingNewWallet/total: -33%
  • solanaAssetDetails/assetClickToPriceChart: -70%
  • solanaAssetDetails/total: -70%
  • solanaAssetDetails/cls: +1620%
  • importSrpHome/openAccountMenuAfterLogin: +21%
  • importSrpHome/homeAfterImportWithNewWallet: +18%
  • importSrpHome/longTaskCount: -19%
  • importSrpHome/longTaskTotalDuration: -39%
  • importSrpHome/longTaskMaxDuration: -15%
  • importSrpHome/tbt: -41%
  • importSrpHome/total: +12%
  • importSrpHome/inp: -30%
  • importSrpHome/lcp: -56%
  • importSrpHome/cls: -47%
  • sendTransactions/openSendPageFromHome: -36%
  • sendTransactions/selectTokenToSendFormLoaded: -55%
  • sendTransactions/reviewTransactionToConfirmationPage: +19%
  • sendTransactions/longTaskCount: -20%
  • sendTransactions/longTaskTotalDuration: -18%
  • sendTransactions/total: +18%
  • sendTransactions/inp: -15%
  • sendTransactions/lcp: -12%
  • sendTransactions/cls: -40%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 importSrpHome/FCP: p75 1.8s
  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 38.34 KiB (0.35%)
  • ui: 18.65 KiB (0.11%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 420 Bytes (0.02%)
  • zip: 19.77 KiB (0.07%)

Fix Test lint TypeScript error after trackHardwareWalletRecoveryConnectCtaClicked
now expects AnalyticsEvent trackEvent from useAnalytics.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
Builds ready [32e9bc2]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 15 pass · 🟡 9 warn · 🔴 0 fail)

Baseline (latest main): 1716549 | Date: 6/29/2026 | Pipeline: 28521406648 | Baseline logs

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: +41%
  • loadNewAccount/total: +41%
  • loadNewAccount/inp: +15%
  • confirmTx/inp: +12%
  • bridgeUserActions/bridge_load_page: -31%
  • bridgeUserActions/bridge_load_asset_picker: +14%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -21%
  • bridgeUserActions/inp: -22%
  • loadNewAccount/load_new_account: +76%
  • loadNewAccount/total: +76%
  • loadNewAccount/lcp: +1165%
  • confirmTx/confirm_tx: +14%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +14%
  • confirmTx/lcp: +1178%
  • bridgeUserActions/bridge_load_page: +100%
  • bridgeUserActions/bridge_load_asset_picker: +93%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +19%
  • bridgeUserActions/inp: +38%
  • bridgeUserActions/fcp: -47%
  • bridgeUserActions/lcp: +1242%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.8s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/numNetworkReqs: +10%
  • startupStandardHome/domInteractive: -29%
  • startupStandardHome/fcp: -26%
  • startupPowerUserHome/uiStartup: -27%
  • startupPowerUserHome/load: -26%
  • startupPowerUserHome/domContentLoaded: -26%
  • startupPowerUserHome/domInteractive: -49%
  • startupPowerUserHome/backgroundConnect: -42%
  • startupPowerUserHome/firstReactRender: -24%
  • startupPowerUserHome/loadScripts: -26%
  • startupPowerUserHome/setupStore: -24%
  • startupPowerUserHome/inp: -31%
  • startupPowerUserHome/fcp: -50%
  • startupPowerUserHome/lcp: -28%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/LCP: p75 2.6s
User Journey Benchmarks · Samples: 5 · mock API
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
🟡 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: -35%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -51%
  • onboardingImportWallet/longTaskCount: -80%
  • onboardingImportWallet/longTaskTotalDuration: -92%
  • onboardingImportWallet/longTaskMaxDuration: -88%
  • onboardingImportWallet/tbt: -96%
  • onboardingImportWallet/total: -83%
  • onboardingNewWallet/agreeButtonToOnboardingSuccess: +17%
  • onboardingNewWallet/doneButtonToAssetList: -51%
  • onboardingNewWallet/longTaskCount: -50%
  • onboardingNewWallet/longTaskTotalDuration: -56%
  • onboardingNewWallet/longTaskMaxDuration: -22%
  • onboardingNewWallet/tbt: -56%
  • onboardingNewWallet/total: -44%
  • solanaAssetDetails/assetClickToPriceChart: -54%
  • solanaAssetDetails/total: -54%
  • solanaAssetDetails/cls: +1178%
  • importSrpHome/openAccountMenuAfterLogin: +33%
  • importSrpHome/longTaskCount: -27%
  • importSrpHome/longTaskTotalDuration: -35%
  • importSrpHome/longTaskMaxDuration: -16%
  • importSrpHome/tbt: -36%
  • importSrpHome/inp: -24%
  • importSrpHome/lcp: -59%
  • importSrpHome/cls: -47%
  • sendTransactions/openSendPageFromHome: -38%
  • sendTransactions/selectTokenToSendFormLoaded: -42%
  • sendTransactions/reviewTransactionToConfirmationPage: +49%
  • sendTransactions/longTaskCount: -20%
  • sendTransactions/longTaskTotalDuration: -26%
  • sendTransactions/longTaskMaxDuration: -10%
  • sendTransactions/tbt: -55%
  • sendTransactions/total: +48%
  • sendTransactions/inp: -15%
  • sendTransactions/lcp: -15%
  • sendTransactions/cls: -40%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.8s
  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 importSrpHome/FCP: p75 1.8s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 38.34 KiB (0.35%)
  • ui: 18.63 KiB (0.11%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 420 Bytes (0.02%)
  • zip: 19.77 KiB (0.07%)

@gauthierpetetin gauthierpetetin self-assigned this Jul 1, 2026
@gauthierpetetin
gauthierpetetin marked this pull request as ready for review July 1, 2026 14:09
@gauthierpetetin
gauthierpetetin requested review from a team as code owners July 1, 2026 14:09
@gauthierpetetin
gauthierpetetin enabled auto-merge July 1, 2026 16:10
GeorgeGkas
GeorgeGkas previously approved these changes Jul 2, 2026
…modal

Remove static createEventBuilder import and pass hook-provided builder
through trackHwRecoveryEvent and callback dependency arrays.

Co-authored-by: Cursor <cursoragent@cursor.com>
@metamask-ci

metamask-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
Builds ready [a4b3e3a]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 16 pass · 🟡 7 warn · 🔴 1 fail)

Baseline (latest main): 1716549 | Date: 6/29/2026 | Pipeline: 28650187603 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
🔴 load_new_account
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -19%
  • loadNewAccount/total: -19%
  • loadNewAccount/inp: -18%
  • confirmTx/tbt: -14%
  • bridgeUserActions/bridge_load_page: -29%
  • bridgeUserActions/longTaskCount: +67%
  • bridgeUserActions/longTaskTotalDuration: +27%
  • bridgeUserActions/longTaskMaxDuration: -20%
  • bridgeUserActions/tbt: -49%
  • bridgeUserActions/inp: -14%
  • loadNewAccount/load_new_account: +530%
  • loadNewAccount/total: +530%
  • loadNewAccount/inp: -18%
  • loadNewAccount/fcp: -50%
  • loadNewAccount/lcp: +1107%
  • confirmTx/confirm_tx: +12%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +12%
  • confirmTx/inp: +12%
  • confirmTx/lcp: +1155%
  • bridgeUserActions/bridge_load_page: +103%
  • bridgeUserActions/bridge_load_asset_picker: +33%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/inp: -14%
  • bridgeUserActions/lcp: +1207%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 loadNewAccount/FCP: p75 1.9s
  • 🟡 confirmTx/FCP: p75 1.9s
  • 🟡 bridgeUserActions/FCP: p75 1.9s
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/setupStore: -15%
  • startupStandardHome/domInteractive: -27%
  • startupStandardHome/fcp: -24%
  • startupPowerUserHome/setupStore: -85%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 224ms
  • 🟡 startupPowerUserHome/LCP: p75 3.4s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟢 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: -14%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -98%
  • onboardingImportWallet/longTaskCount: -80%
  • onboardingImportWallet/longTaskTotalDuration: -89%
  • onboardingImportWallet/longTaskMaxDuration: -86%
  • onboardingImportWallet/tbt: -95%
  • onboardingImportWallet/total: -85%
  • onboardingNewWallet/doneButtonToAssetList: -37%
  • onboardingNewWallet/longTaskCount: -50%
  • onboardingNewWallet/longTaskTotalDuration: -58%
  • onboardingNewWallet/longTaskMaxDuration: -27%
  • onboardingNewWallet/tbt: -64%
  • onboardingNewWallet/total: -32%
  • solanaAssetDetails/assetClickToPriceChart: -70%
  • solanaAssetDetails/total: -70%
  • solanaAssetDetails/cls: +1172%
  • importSrpHome/loginToHomeScreen: -16%
  • importSrpHome/longTaskCount: -27%
  • importSrpHome/longTaskTotalDuration: -36%
  • importSrpHome/longTaskMaxDuration: -17%
  • importSrpHome/tbt: -36%
  • importSrpHome/inp: -27%
  • importSrpHome/lcp: -60%
  • importSrpHome/cls: -47%
  • sendTransactions/openSendPageFromHome: -25%
  • sendTransactions/selectTokenToSendFormLoaded: -53%
  • sendTransactions/reviewTransactionToConfirmationPage: -18%
  • sendTransactions/longTaskCount: -20%
  • sendTransactions/longTaskTotalDuration: -26%
  • sendTransactions/longTaskMaxDuration: -10%
  • sendTransactions/tbt: -55%
  • sendTransactions/total: -18%
  • sendTransactions/lcp: -20%
  • sendTransactions/cls: -40%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 1.8s
  • 🟡 sendTransactions/FCP: p75 2.0s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 46.71 KiB (0.42%)
  • ui: 44.21 KiB (0.26%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 570 Bytes (0.03%)
  • zip: 30.6 KiB (0.11%)

ccharly
ccharly previously approved these changes Jul 3, 2026

@ccharly ccharly left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for accounts:

ui/contexts/hardware-wallets/useHardwareWalletMetrics.test.tsx
ui/contexts/hardware-wallets/useHardwareWalletMetrics.ts
ui/pages/create-account/connect-hardware/account-list.tsx
ui/pages/create-account/connect-hardware/index.test.tsx
ui/pages/create-account/connect-hardware/index.tsx
ui/pages/create-account/connect-hardware/select-hardware.stories.tsx
ui/pages/create-account/connect-hardware/select-hardware.test.tsx
ui/pages/create-account/connect-hardware/select-hardware.tsx

GeorgeGkas
GeorgeGkas previously approved these changes Jul 3, 2026
…ardware

Keep all useAnalytics Storybook aliases from both sides and use main's typed
useAnalytics mock.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

@metamask-ci

metamask-ci Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
Builds ready [f9ca58f]
Deprecated Browserify fallback builds
⚡ Performance Benchmarks (Total: 🟢 18 pass · 🟡 6 warn · 🔴 1 fail)

Baseline (latest main): 1716549 | Date: 6/29/2026 | Pipeline: 28780597953 | Baseline logs

Metricschrome-webpackfirefox-webpack
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]

Regressions (🔴 1 failure)

Interaction Benchmarks · Samples: 5
Benchmarkchrome-webpackfirefox-webpack
loadNewAccount
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
confirmTx
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
bridgeUserActions
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • loadNewAccount/load_new_account: -28%
  • loadNewAccount/total: -28%
  • loadNewAccount/fcp: -33%
  • loadNewAccount/lcp: -21%
  • confirmTx/longTaskTotalDuration: -32%
  • confirmTx/longTaskMaxDuration: -32%
  • confirmTx/tbt: -60%
  • confirmTx/inp: -29%
  • confirmTx/fcp: -27%
  • confirmTx/lcp: -19%
  • bridgeUserActions/bridge_load_page: -54%
  • bridgeUserActions/bridge_load_asset_picker: -45%
  • bridgeUserActions/longTaskCount: -17%
  • bridgeUserActions/longTaskTotalDuration: -47%
  • bridgeUserActions/longTaskMaxDuration: -40%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: -19%
  • bridgeUserActions/inp: -40%
  • bridgeUserActions/fcp: -30%
  • loadNewAccount/load_new_account: +46%
  • loadNewAccount/total: +46%
  • loadNewAccount/inp: -18%
  • loadNewAccount/fcp: -56%
  • loadNewAccount/lcp: +1055%
  • confirmTx/confirm_tx: +10%
  • confirmTx/longTaskCount: -100%
  • confirmTx/longTaskTotalDuration: -100%
  • confirmTx/longTaskMaxDuration: -100%
  • confirmTx/tbt: -100%
  • confirmTx/total: +10%
  • confirmTx/lcp: +1053%
  • bridgeUserActions/bridge_load_page: +124%
  • bridgeUserActions/bridge_load_asset_picker: +74%
  • bridgeUserActions/longTaskCount: -100%
  • bridgeUserActions/longTaskTotalDuration: -100%
  • bridgeUserActions/longTaskMaxDuration: -100%
  • bridgeUserActions/tbt: -100%
  • bridgeUserActions/total: +17%
  • bridgeUserActions/inp: -14%
  • bridgeUserActions/lcp: +1122%
Startup Benchmarks · Samples: 100
Benchmarkchrome-webpackfirefox-webpack
startupStandardHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
startupPowerUserHome
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]

📈 Results compared to the previous 5 runs on main

  • startupStandardHome/numNetworkReqs: +10%
  • startupPowerUserHome/uiStartup: -20%
  • startupPowerUserHome/load: -20%
  • startupPowerUserHome/domContentLoaded: -21%
  • startupPowerUserHome/domInteractive: -20%
  • startupPowerUserHome/firstPaint: -11%
  • startupPowerUserHome/backgroundConnect: -22%
  • startupPowerUserHome/firstReactRender: -23%
  • startupPowerUserHome/initialActions: -33%
  • startupPowerUserHome/loadScripts: -20%
  • startupPowerUserHome/setupStore: -26%
  • startupPowerUserHome/longTaskCount: -25%
  • startupPowerUserHome/longTaskTotalDuration: -30%
  • startupPowerUserHome/longTaskMaxDuration: -22%
  • startupPowerUserHome/tbt: -30%
  • startupPowerUserHome/inp: -18%
  • startupPowerUserHome/fcp: -20%
  • startupPowerUserHome/lcp: +220%
  • startupStandardHome/domInteractive: -23%
  • startupStandardHome/fcp: -21%
  • startupPowerUserHome/inp: -20%
  • startupPowerUserHome/fcp: -11%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 startupPowerUserHome/INP: p75 448ms
  • 🟡 startupPowerUserHome/LCP: p75 3.7s
User Journey Benchmarks · Samples: 5 · mock API 🔴 1
Benchmarkchrome-webpackfirefox-webpack
onboardingImportWallet
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
onboardingNewWallet
[Sentry log · main/release]
🟢 [CI log]🔴 [CI log]
🔴 total
assetDetails
[Sentry log · main/release]
🟡 [CI log]🟡 [CI log]
solanaAssetDetails
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
importSrpHome
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]
sendTransactions
[Sentry log · main/release]
🟢 [CI log]🟡 [CI log]
swap
[Sentry log · main/release]
🟢 [CI log]🟢 [CI log]

📈 Results compared to the previous 5 runs on main

  • onboardingImportWallet/metricsToWalletReadyScreen: -16%
  • onboardingImportWallet/doneButtonToHomeScreen: -86%
  • onboardingImportWallet/openAccountMenuToAccountListLoaded: -97%
  • onboardingImportWallet/longTaskCount: -80%
  • onboardingImportWallet/longTaskTotalDuration: -94%
  • onboardingImportWallet/longTaskMaxDuration: -91%
  • onboardingImportWallet/tbt: -99%
  • onboardingImportWallet/total: -85%
  • onboardingNewWallet/skipBackupToMetricsScreen: +13%
  • onboardingNewWallet/doneButtonToAssetList: -26%
  • onboardingNewWallet/longTaskTotalDuration: -33%
  • onboardingNewWallet/longTaskMaxDuration: -34%
  • onboardingNewWallet/tbt: -71%
  • onboardingNewWallet/total: -22%
  • solanaAssetDetails/assetClickToPriceChart: -72%
  • solanaAssetDetails/total: -72%
  • solanaAssetDetails/inp: -17%
  • solanaAssetDetails/cls: +1620%
  • importSrpHome/openAccountMenuAfterLogin: -22%
  • importSrpHome/longTaskCount: -35%
  • importSrpHome/longTaskTotalDuration: -24%
  • importSrpHome/longTaskMaxDuration: -18%
  • importSrpHome/tbt: -40%
  • importSrpHome/inp: -30%
  • importSrpHome/lcp: -54%
  • importSrpHome/cls: -47%
  • sendTransactions/openSendPageFromHome: -37%
  • sendTransactions/selectTokenToSendFormLoaded: -58%
  • sendTransactions/longTaskCount: -20%
  • sendTransactions/longTaskTotalDuration: -29%
  • sendTransactions/longTaskMaxDuration: -14%
  • sendTransactions/tbt: -70%
  • sendTransactions/inp: -11%
  • sendTransactions/lcp: -16%
  • sendTransactions/cls: -40%

🌐 Core Web Vitals — 🟢 good · 🟡 needs improvement · 🔴 poor (web.dev thresholds)

  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 assetDetails/FCP: p75 1.9s
  • 🟡 solanaAssetDetails/FCP: p75 1.9s
  • 🟡 sendTransactions/FCP: p75 1.9s
Dapp Page Load Benchmarks · Samples: 100
Benchmarkchrome-webpack
dappPageLoad
[Sentry log · main/release]
🟢 [CI log]
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 69.92 KiB (0.63%)
  • ui: 42.2 KiB (0.24%)
  • common: 0 Bytes (0%)
  • other: 0 Bytes (0%)
  • contentScripts: 726 Bytes (0.04%)
  • zip: 32.86 KiB (0.12%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.40.0 Issue or pull request that will be included in release 13.40.0 risk:low size-L team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants