chore: bridge:submitTx calls the TransactionController's handlers through the messenger#8188
Open
chore: bridge:submitTx calls the TransactionController's handlers through the messenger#8188
Conversation
…aps3560-submitTx-handlers
…aps3560-submitTx-handlers
Base automatically changed from
swaps4229-refactor-bridge-status-test-coverage
to
main
March 12, 2026 16:16
packages/bridge-status-controller/src/bridge-status-controller.intent-manager.test.ts
Show resolved
Hide resolved
950e053 to
0550c87
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
This change replaces the transaction handlers provided to the
BridgeStatusControllerconstructor with calls to the TransactionController, through the controller messengerTo migrate:
TransactionControllerUpdateTransactionAction,TransactionControllerAddTransactionAction, andTransactionControllerEstimateGasFeeActionpermissions to their controller init modules in addition to updating the constructorBridgeStatusControllerconstructorReferences
Fixes https://consensyssoftware.atlassian.net/browse/SWAPS-3560
Checklist
Note
High Risk
Breaking API change:
BridgeStatusControllerno longer accepts injected transaction handler functions and now performsaddTransaction,estimateGasFee, andupdateTransactionvia messenger permissions, affecting transaction submission and intent status syncing paths.Overview
BREAKING:
BridgeStatusControllernow callsTransactionControlleroperations via the controller messenger (e.g.TransactionController:addTransaction,TransactionController:estimateGasFee,TransactionController:updateTransaction) instead of using handler functions passed into the constructor.This updates intent syncing (
IntentManager) and batch post-processing (findAndUpdateTransactionsInBatch) to use messenger calls, extends allowed action permissions intypes.ts, and refreshes unit tests/snapshots to assert the new messenger call sequences. TheCHANGELOG.mddocuments the required client migration (new permissions + constructor signature update).Written by Cursor Bugbot for commit a7fa55e. This will update automatically on new commits. Configure here.