Skip to content

feat: add address poisoning detection to PhishingController #8171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AugmentedMode wants to merge 7 commits into
base: main
Choose a base branch
from
+776 −23
Open

feat: add address poisoning detection to PhishingController #8171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bff69ae
feat: add address poisoning detection to PhishingController
AugmentedMode Mar 10, 2026
f6ce4ef
update yarn
AugmentedMode Mar 10, 2026
2c0cedd
fix
AugmentedMode Mar 10, 2026
2d624c9
fix errors
AugmentedMode Mar 10, 2026
78f3d48
fix
AugmentedMode Mar 10, 2026
f5c1825
fix: changelog
AugmentedMode Mar 11, 2026
e2235a7
fix
AugmentedMode Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions eslint-suppressions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,14 +1281,11 @@
"packages/phishing-controller/src/PhishingController.test.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 1
},
"jest/unbound-method": {
"count": 7
}
},
"packages/phishing-controller/src/PhishingController.ts": {
"@typescript-eslint/explicit-function-return-type": {
"count": 25
"count": 20
},
"@typescript-eslint/naming-convention": {
"count": 1
Expand Down
7 changes: 7 additions & 0 deletions packages/phishing-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `findSimilarAddresses` utility and `PhishingController:checkAddressPoisoning` messenger action to detect address poisoning attempts against known recipients ([#8171](https://github.com/MetaMask/core/pull/8171))
- The controller now hydrates and maintains a set of known recipient addresses from confirmed transactions (`TransactionController`) and the address book (`AddressBookController`)
- Exposes match metadata including prefix/suffix match lengths, poisoning score, and diff indices
- Add `@metamask/address-book-controller` as a dependency ([#8171](https://github.com/MetaMask/core/pull/8171))

### Changed

- Bump `@metamask/transaction-controller` from `^62.17.0` to `^62.21.0` ([#7996](https://github.com/MetaMask/core/pull/7996), [#8005](https://github.com/MetaMask/core/pull/8005), [#8031](https://github.com/MetaMask/core/pull/8031), [#8104](https://github.com/MetaMask/core/pull/8104), [#8140](https://github.com/MetaMask/core/pull/8140))
Expand Down
1 change: 1 addition & 0 deletions packages/phishing-controller/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/address-book-controller": "^7.0.1",
"@metamask/base-controller": "^9.0.0",
"@metamask/controller-utils": "^11.19.0",
"@metamask/messenger": "^0.3.0",
Expand Down
Loading
Loading