feat: Add eBTC token metadata and logo on Optimism#1781
Open
jtfirek wants to merge 1 commit intoMetaMask:masterfrom
Open
feat: Add eBTC token metadata and logo on Optimism#1781jtfirek wants to merge 1 commit intoMetaMask:masterfrom
jtfirek wants to merge 1 commit intoMetaMask:masterfrom
Conversation
Made-with: Cursor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Reviewed by Cursor Bugbot for commit a1e0002. Configure here.
| @@ -0,0 +1,7 @@ | |||
| { | |||
| "name": "ether.fi BTC", | |||
There was a problem hiding this comment.
Token name inconsistent with existing mainnet entry
Low Severity
The name field is "ether.fi BTC" here, but the same contract address on Ethereum mainnet (eip155:1) is registered as "ether.fi Staked BTC" in this repo's existing metadata and in contract-map.json. CoinMarketCap also lists it as "ether.fi Staked BTC." This discrepancy means the same token will display different names depending on the chain, which could confuse users. Worth verifying the on-chain name() return value and aligning both entries.
Reviewed by Cursor Bugbot for commit a1e0002. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


📑 Description
eBTC is ether.fi's BTC product on Optimism. Contract is verified on Etherscan.
✅ Checks
Made with Cursor
Note
Low Risk
Low risk: this PR only adds static ERC-20 metadata and an SVG asset, with no runtime logic changes.
Overview
Adds Optimism (chain
eip155:10) ERC-20 metadata forether.fi BTC(eBTC) at0x657e8C867D8B37dCC18fA4Caead9C45EB088C642, includingdecimals: 8and a logo reference.Includes the corresponding new SVG token icon at
icons/eip155:10/erc20:0x657e8C867D8B37dCC18fA4Caead9C45EB088C642.svg.Reviewed by Cursor Bugbot for commit a1e0002. Bugbot is set up for automated code reviews on this repo. Configure here.