Skip to content

fix: TeamMemberSplit.teamId has no index despite being the delete/join key (fixes #349) #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
themaksat wants to merge 1 commit into from
Closed

fix: TeamMemberSplit.teamId has no index despite being the delete/join key (fixes #349) #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 16 additions & 22 deletions src/common/entities/team-member-split.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import {
Column,
CreateDateColumn,
Entity,
JoinColumn,
ManyToOne,
PrimaryGeneratedColumn,
Column,
ManyToOne,
JoinColumn,
Index,
} from 'typeorm';
import { Team } from './team.entity';
import { User } from './user.entity';
Expand All @@ -14,28 +14,22 @@ export class TeamMemberSplit {
@PrimaryGeneratedColumn('uuid')
id: string;

@ManyToOne(() => Team, (team) => team.splits, { onDelete: 'CASCADE' })
@JoinColumn()
team: Team;

@Column()
// Adding an index on teamId improves delete and join performance
@Index()
@Column({ type: 'uuid' })
teamId: string;

@ManyToOne(() => User, { onDelete: 'CASCADE' })
@JoinColumn()
user: User;

@Column()
@Column({ type: 'uuid' })
userId: string;

/** Free-text label describing the member's contribution, e.g. "frontend". */
@Column({ type: 'varchar', length: 50, nullable: true })
role: string | null;
@Column('decimal', { precision: 5, scale: 2 })
percentage: number;

/** Percentage of the bounty payout, 0-100. Sum across a team must equal 100. */
@Column({ type: 'decimal', precision: 5, scale: 2 })
percentage: string;
@ManyToOne(() => Team, (team) => team.splits, { onDelete: 'CASCADE' })
@JoinColumn({ name: 'teamId' })
team: Team;

@CreateDateColumn()
createdAt: Date;
@ManyToOne(() => User, (user) => user.teamSplits)
@JoinColumn({ name: 'userId' })
user: User;
}