fix(memos-local-openclaw): Viewer API search limit and minScore params not working

[zerone0x]

Description

Fix the /api/search endpoint in apps/memos-local-openclaw/src/viewer/server.ts where limit and minScore query parameters were being completely ignored.

Changes

• Read limit from query params (clamped to 1-100, default 20)
• Read minScore from query params (clamped to 0.35-1.0, default 0.64)
• Use minScore as the semantic similarity threshold instead of the hardcoded 0.64
• Truncate final results array by limit
• Include limit and minScore in the JSON response

Related Issue

Fixes #1372

Type of Change

• Bug fix (non-breaking change which fixes an issue)

[Copilot]

Pull request overview

Fixes the memos-local-openclaw Viewer /api/search endpoint so callers can control search result size (limit) and semantic similarity threshold (minScore), addressing the bug reported in #1372.

Changes:

• Parse limit and minScore from query params (with clamping and defaults).
• Use minScore instead of a hardcoded semantic threshold during vector-hit filtering.
• Truncate the final response results to limit and include limit/minScore in the response payload.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The query param parsing uses Number(...) || default, which treats 0 as “missing”. That makes limit=0 default to 20 (instead of clamping to 1) and minScore=0 default to 0.64 (instead of clamping to 0.35). Consider parsing with Number.isFinite and applying the default only when the param is absent/NaN, then clamp the resulting value.

Suggested change

	const limit = Math.min(100, Math.max(1, Number(url.searchParams.get("limit")) || 20));
	const minScore = Math.max(0.35, Math.min(1, Number(url.searchParams.get("minScore")) || 0.64));
	const rawLimit = Number(url.searchParams.get("limit"));
	const limit = Math.min(100, Math.max(1, Number.isFinite(rawLimit) ? rawLimit : 20));
	const rawMinScore = Number(url.searchParams.get("minScore"));
	const minScore = Math.max(0.35, Math.min(1, Number.isFinite(rawMinScore) ? rawMinScore : 0.64));

[Copilot]

merged always includes ftsResults (the second loop appends them unconditionally), so the merged.length > 0 ? merged : ftsResults.slice(...) branch is effectively redundant. Simplifying this to a single slice of merged would make the intent clearer and avoid implying there’s a distinct fallback path.

Suggested change

	const results = (merged.length > 0 ? merged : ftsResults.slice(0, limit)).slice(0, limit);
	const results = merged.slice(0, limit);

[Copilot]

This endpoint change is user-visible (new limit/minScore behavior + response fields) but there doesn’t appear to be coverage for /api/search query-param handling. Given the repo already has integration tests that spin up ViewerServer and call endpoints via fetch, please add a test asserting (a) results are truncated to limit and (b) minScore affects semantic hit inclusion (and that values are clamped to the documented ranges).

Suggested change

	const limit = Math.min(100, Math.max(1, Number(url.searchParams.get("limit")) || 20));
	const minScore = Math.max(0.35, Math.min(1, Number(url.searchParams.get("minScore")) || 0.64));
	const rawLimit = Number(url.searchParams.get("limit"));
	const limit = Math.min(100, Math.max(1, Number.isFinite(rawLimit) ? rawLimit : 20));
	const rawMinScore = Number(url.searchParams.get("minScore"));
	const minScore = Math.max(0.35, Math.min(1, Number.isFinite(rawMinScore) ? rawMinScore : 0.64));