fix: Notes app on a space page named wiki displays personal notes - EXO-89534 - #1754
Merged
Conversation
…XO-89534 (#1753) The legacy wiki-to-notes redirect filter rewrote any URL containing a "wiki" segment to "notes", unconditionally. A space page whose node URI is "wiki" was therefore never rendered: the request was redirected to a "notes" node the space does not have, the portal fell back to the global portal-site notes page, and outside the group site the Notes app resolves the viewer's personal notebook instead of the space one. The filter now redirects only genuinely legacy URLs: it resolves the site addressed by the URL (group, space id or portal forms) and skips the rewrite when that site's navigation actually contains a "wiki" node, so the page renders in its own site context and the Notes app picks the space notebook. A "wiki" segment at the site-name position is no longer rewritten, and the redirect now preserves the query string. Unresolvable sites keep the previous behavior (redirect), as do WikiPortlet URLs.
AzmiTouil
enabled auto-merge (squash)
August 26, 2026 13:07
|
ahamdi
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy wiki-to-notes redirect filter rewrote any URL containing a "wiki" segment to "notes", unconditionally. A space page whose node URI is "wiki" was therefore never rendered: the request was redirected to a "notes" node the space does not have, the portal fell back to the global portal-site notes page, and outside the group site the Notes app resolves the viewer's personal notebook instead of the space one.
The filter now redirects only genuinely legacy URLs: it resolves the site addressed by the URL (group, space id or portal forms) and skips the rewrite when that site's navigation actually contains a "wiki" node, so the page renders in its own site context and the Notes app picks the space notebook. A "wiki" segment at the site-name position is no longer rewritten, and the redirect now preserves the query string. Unresolvable sites keep the previous behavior (redirect), as do WikiPortlet URLs.