feat: Digest mail notifications - eXIP7.3.0.22 - integration into feature/mips

[azayati]

eXIP 7.3.0.22 — Digest mail notifications · integration into feature/mips

Removal of the makeDigest overrides of the legacy digest engine, meaningless since the abstract method left commons-api. No functional change.

The 1 commit(s) replayed from feature/experience

• 0fadfb8fe fix: Remove the legacy digest hooks of the notifications - EXO-90072 (fix: Remove the legacy digest hooks of the notifications - EXO-90072 - eXIP7.3.0.22 #2004)

5 files changed, 4 insertions(+), 94 deletions(-)

How this branch was built

exip-7.3.0.22-mips starts from origin/feature/mips and replays only the commits tagged eXIP7.3.0.22 (git cherry-pick -x, the original reference is in every message). The FB version-bump commit (Task-87990) and the commits of the other eXIPs present on feature/experience are deliberately left out — no pom.xml is touched.

Merge order

makeDigest is still an abstract method of commons-api on feature/mips; the other 18 PRs remove their overrides, so they only compile once commons is merged: commons#786 first (wait for the Nexus snapshot), then social#6093, then the 17 addons in any order.

Classification

N1 for the whole eXIP (Liquibase schema and JPA entities, the commons notification dispatcher, new REST endpoints, mass email sending). Approver ≠ author: this PR must be approved by an Architect / Senior Developer who knows it is N1, not on the AI review alone.

Already validated on feature/experience

Every US of the board (project 8372) is "Tested & Validated" by the PO, the legacy engine cleanup (EXO-90072, 19 repositories) included. Full functional test plan: capture, daily and weekly contents, timezones, catch-up at startup, safety cleanup, and non-regression of the instant notifications.

Knowledge: TODO — eng-standards PR to open (/domain-doc commons + social) before leaving draft

🤖 Generated with Claude Code

[azayati]

AI review — Round #1 — eXIP 7.3.0.22 Digest mail notifications (legacy cleanup)

Reviewed as one delivery with the 18 sibling PRs, at head 0fadfb8f. No finding.

Verified conform: a pure removal of the makeDigest override(s) of the legacy digest engine and of the now-unused java.io.Writer import; no other hunk, no behaviour change. (Also AbstractPluginTest adapted to social’s MockNotificationService losing its digest store — storeDigest → storeInstantly, digest helpers dropped.)

Classification: N1 by aggregation with the eXIP (the diff itself is a pure removal). Compiles only once commons#786 is on Nexus. Knowledge: line still TODO.

🤖 Generated with Claude Code

[boubaker]

AI review — Round #2 (independent review, Architects Lead's reviewer)

Independent pass at 0fadfb8f, as part of the 19-PR delivery reviewed against Tech Spec note 50469 and board 8372 (delivery summary and the engine findings on commons#786).

Verified conform: a pure removal of the legacy makeDigest override(s) / digest hooks; no other hunk, no behaviour change; no makeDigest, buildDigest or legacy digest symbol remains at head; no now-unused import left by the removal (checked on every touched file); no copyright year moved.

No finding.

Classification: N1 by aggregation with the eXIP (the diff itself is a pure removal). Compiles once commons#786 is on Nexus. Knowledge: still TODO on the body.

🤖 Generated with Claude Code