Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The cap-height offset needs a fallback for the configured Safari 16 target.
1 open issue
What changed in this PR
This PR adjusts task checkbox alignment in the editor’s hidden-syntax mode to follow the text’s cap height rather than a fixed line-height slot.
Changes:
- Uses baseline-aligned controls and cap-height positioning.
- Places the checkbox control before the hidden list marker.
- Updates style assertions and the lite bundle.
| File | Description |
|---|---|
tests/hiddenSyntax/unorderedList.test.ts |
Checks the new positioning rules and DOM order. |
src/hiddenSyntax/components/task.ts |
Implements cap-height checkbox alignment. |
dist/lite/markedit-preview.js |
Includes the updated task checkbox implementation. |
Review effort: Balanced
cyanzhong
force-pushed
the
develop
branch
2 times, most recently
from
October 23, 2026 08:39
357af0a to
e2e66f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.