Conversation
Google 56 introduced passive mode to default be true. The script will throw errors
|
I support this PR.. get rid of there annoying errors! :) |
|
@pazguille Would be great if you could merge this. |
nicolaelitvac
left a comment
There was a problem hiding this comment.
Would be nice to have this merged to master!
sun
left a comment
There was a problem hiding this comment.
Not sure whether the copy of the script in index.js also needs to be updated:
https://github.com/Mango/slideout/blob/master/index.js#L209
https://github.com/Mango/slideout/blob/master/index.js#L300
sun
left a comment
There was a problem hiding this comment.
The code primarily needs to be fixed in index.js, the files in dist are compiled.
Also note that this issue has been fixed in v2 in the branch new-features already, but that code hasn't been released in any way yet:
https://github.com/Mango/slideout/compare/new-features#diff-168726dbe96b3ce427e7fedce31bb0bcR237
|
Can this be patched for the current stable release so we can improve lighthouse speeds? |
Google 56 introduced passive mode to default be true. The script will
throw errors