Skip to content

Fix google passive error#267

Open
TijmenGraft wants to merge 1 commit intoMango:masterfrom
TijmenGraft:master
Open

Fix google passive error#267
TijmenGraft wants to merge 1 commit intoMango:masterfrom
TijmenGraft:master

Conversation

@TijmenGraft
Copy link
Copy Markdown

Google 56 introduced passive mode to default be true. The script will
throw errors

Google 56 introduced passive mode to default be true. The script will
throw errors
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 69.88% when pulling 6fff875 on TijmenGraft:master into 6eb8440 on Mango:master.

@andreasroste
Copy link
Copy Markdown

I support this PR.. get rid of there annoying errors! :)

@joker-777
Copy link
Copy Markdown

@pazguille Would be great if you could merge this.

Copy link
Copy Markdown

@nicolaelitvac nicolaelitvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have this merged to master!

Copy link
Copy Markdown

@sun sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether the copy of the script in index.js also needs to be updated:
https://github.com/Mango/slideout/blob/master/index.js#L209
https://github.com/Mango/slideout/blob/master/index.js#L300

Copy link
Copy Markdown

@sun sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code primarily needs to be fixed in index.js, the files in dist are compiled.

Also note that this issue has been fixed in v2 in the branch new-features already, but that code hasn't been released in any way yet:
https://github.com/Mango/slideout/compare/new-features#diff-168726dbe96b3ce427e7fedce31bb0bcR237

@inoas
Copy link
Copy Markdown

inoas commented Apr 10, 2020

Can this be patched for the current stable release so we can improve lighthouse speeds?

inoas added a commit to inoas/slideout that referenced this pull request Apr 10, 2020
@inoas
Copy link
Copy Markdown

inoas commented Apr 10, 2020

@sun I have taken over what you suggested in #295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants