Skip to content

feat(drop): configure excellent item drop monster level delta#746

Open
olisikh wants to merge 2 commits intoMUnique:masterfrom
olisikh:feat/exc_item_drop_control
Open

feat(drop): configure excellent item drop monster level delta#746
olisikh wants to merge 2 commits intoMUnique:masterfrom
olisikh:feat/exc_item_drop_control

Conversation

@olisikh
Copy link
Copy Markdown
Contributor

@olisikh olisikh commented Apr 4, 2026

Allow to configure excellent items drop delta which defines what monster level specific item starts dropping from (i.e. normal item monster level + 25)

Kept default value of 25.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a configurable level delta for excellent item drops, replacing a previously hardcoded value. This change provides server administrators with greater flexibility in balancing item drop mechanics by allowing them to define the specific monster level threshold required for excellent items to drop relative to an item's base level.

Highlights

  • Configuration Enhancement: Added a new configurable property 'ExcellentItemDropLevelDelta' to 'GameConfiguration' to control the monster level requirement for excellent item drops.
  • Logic Update: Updated 'DefaultDropGenerator' to utilize the new configurable delta instead of a hardcoded value of 25.
  • Persistence and Initialization: Included database migrations and updated the configuration initializer to support the new property with a default value of 25.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configurable ExcellentItemDropLevelDelta property to the GameConfiguration, replacing a hardcoded value of 25 in the DefaultDropGenerator. The update includes necessary database migrations, property initialization, and a unit test to verify the new configuration option. I have no feedback to provide.

@olisikh olisikh force-pushed the feat/exc_item_drop_control branch 5 times, most recently from ea85893 to 6c000a2 Compare April 4, 2026 22:15
@olisikh olisikh force-pushed the feat/exc_item_drop_control branch from 6c000a2 to b61edec Compare April 4, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant