changes to tdc remesh and dev cases - #1042
Merged
Merged
Conversation
Add a native remesh-on-load control and temperature-sensitive interior zoning. Conserve species mass during the envelope remap and use the new zone count for post-remesh bookkeeping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr makes some modifications to the tdc envelope remeshing scheme in preparation for another pr which will introduce star linear analysis and add TDC pulsation test cases as well as convection outputs for gyre with convection support. Nothing in this pr is really touched by the test suite, so i imagine nothing will be affected.
This pr also removes the density form of the tdc eddy viscosity which has proven unstable and not worth keeping.