-
Notifications
You must be signed in to change notification settings - Fork 32
GH-686 Limits on rate-pack values #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still uncertain, this will protect the MASQ Foundation network, because if someone want's to set rate-pack below the limit, it is just one change and cargo build away from doing so and network does not even aknowledge this. I woud like to propose: make an debut_handler rule, that if the debuting node is in standard, or originate-only mode, and have rate pack below (or above) the limits, his debut is dropped on the flor
|
Hey @dnwiebe @czarte - I agree with @czarte comments to add this additional checking in the handlers to ensure Nodes don't have rate-packs outside of the defined limits now, and can be done without too much additional work. This will cover older versions of Node joining network with rates outside the hard-coded limits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Note
Medium Risk
Adds a new persisted configuration field and schema migration (
rate_pack_limits), plus new parsing/validation logic that can affect node startup if existing DB/config values are missing or malformed. Also tweaks accounting charge logging/calculation and integration-test timing/network setup, which could mask or reveal flakiness.Overview
Introduces configurable rate-pack bounds via a new
rate_pack_limitsconfig value, including a schema bump to v12, DB initialization defaults, and a new11→12migration to backfill existing databases.Extends persistent config to parse/validate
rate_pack_limits(regex + ordering checks) and updates setup-reporting test fixtures to use largerrate-packvalues consistent with the new constraints.Separately improves reliability and diagnostics: accountant charge computation is centralized and logs now include the computed wei charge, multinode tests/networking add retries/longer timeouts and adjust HTTP test targets, and gossip/dot-graph output gets minor renames plus
Displayformatting helpers.Written by Cursor Bugbot for commit 4ebf2f6. This will update automatically on new commits. Configure here.